Skip to content

Commit

Permalink
apparmor: Fix some kernel-doc comments
Browse files Browse the repository at this point in the history
Don't use /** for non-kernel-doc comments and change function name
aa_mangle_name to mangle_name in kernel-doc comment to Remove some
warnings found by running scripts/kernel-doc, which is caused by
using 'make W=1'.

security/apparmor/apparmorfs.c:1503: warning: Cannot understand  *
 on line 1503 - I thought it was a doc line
security/apparmor/apparmorfs.c:1530: warning: Cannot understand  *
 on line 1530 - I thought it was a doc line
security/apparmor/apparmorfs.c:1892: warning: Cannot understand  *
 on line 1892 - I thought it was a doc line
security/apparmor/apparmorfs.c:108: warning: expecting prototype for
aa_mangle_name(). Prototype was for mangle_name() instead

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
Signed-off-by: John Johansen <[email protected]>
  • Loading branch information
Yang Li authored and John Johansen committed Jul 9, 2022
1 parent 5ee5d37 commit 564423b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions security/apparmor/apparmorfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static struct rawdata_f_data *rawdata_f_data_alloc(size_t size)
#endif

/**
* aa_mangle_name - mangle a profile name to std profile layout form
* mangle_name - mangle a profile name to std profile layout form
* @name: profile name to mangle (NOT NULL)
* @target: buffer to store mangled name, same length as @name (MAYBE NULL)
*
Expand Down Expand Up @@ -1499,7 +1499,7 @@ int __aa_fs_create_rawdata(struct aa_ns *ns, struct aa_loaddata *rawdata)

/** fns to setup dynamic per profile/namespace files **/

/**
/*
*
* Requires: @profile->ns->lock held
*/
Expand All @@ -1526,7 +1526,7 @@ void __aafs_profile_rmdir(struct aa_profile *profile)
}
}

/**
/*
*
* Requires: @old->ns->lock held
*/
Expand Down Expand Up @@ -1888,7 +1888,7 @@ static void __aa_fs_list_remove_rawdata(struct aa_ns *ns)
__aa_fs_remove_rawdata(ent);
}

/**
/*
*
* Requires: @ns->lock held
*/
Expand Down

0 comments on commit 564423b

Please sign in to comment.