tipc: uninitialized return code in tipc_setsockopt()

We shuffled some code around and added some new case statements here and now "res" isn't initialized on all paths. Fixes: 01fd12b ("tipc: make replicast a user selectable option") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: David S. Miller <[email protected]>
majek · Jan 25, 2017 · a08ef47 · a08ef47
1 parent 1045ba7
commit a08ef47
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
@@ -2348,7 +2348,7 @@ static int tipc_setsockopt(struct socket *sock, int lvl, int opt,
 	struct sock *sk = sock->sk;
 	struct tipc_sock *tsk = tipc_sk(sk);
 	u32 value = 0;
-	int res;
+	int res = 0;
 
 	if ((lvl == IPPROTO_TCP) && (sock->type == SOCK_STREAM))
 		return 0;
@@ -2388,7 +2388,6 @@ static int tipc_setsockopt(struct socket *sock, int lvl, int opt,
 		break;
 	case TIPC_CONN_TIMEOUT:
 		tipc_sk(sk)->conn_timeout = value;
-		/* no need to set "res", since already 0 at this point */
 		break;
 	case TIPC_MCAST_BROADCAST:
 		tsk->mc_method.rcast = false;