Skip to content

Commit

Permalink
Merge tag 'zonefs-5.20-rc1' of git://git.kernel.org/pub/scm/linux/ker…
Browse files Browse the repository at this point in the history
…nel/git/dlemoal/zonefs

Pull zonefs update from Damien Le Moal:
 "A single change for this cycle to simplify handling of the memory page
  used as super block buffer during mount (from Fabio)"

* tag 'zonefs-5.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs:
  zonefs: Call page_address() on page acquired with GFP_KERNEL flag
  • Loading branch information
torvalds committed Aug 3, 2022
2 parents f18d730 + 6bac30b commit a39b5db
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions fs/zonefs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1686,34 +1686,34 @@ static int zonefs_read_super(struct super_block *sb)
if (ret)
goto free_page;

super = kmap(page);
super = page_address(page);

ret = -EINVAL;
if (le32_to_cpu(super->s_magic) != ZONEFS_MAGIC)
goto unmap;
goto free_page;

stored_crc = le32_to_cpu(super->s_crc);
super->s_crc = 0;
crc = crc32(~0U, (unsigned char *)super, sizeof(struct zonefs_super));
if (crc != stored_crc) {
zonefs_err(sb, "Invalid checksum (Expected 0x%08x, got 0x%08x)",
crc, stored_crc);
goto unmap;
goto free_page;
}

sbi->s_features = le64_to_cpu(super->s_features);
if (sbi->s_features & ~ZONEFS_F_DEFINED_FEATURES) {
zonefs_err(sb, "Unknown features set 0x%llx\n",
sbi->s_features);
goto unmap;
goto free_page;
}

if (sbi->s_features & ZONEFS_F_UID) {
sbi->s_uid = make_kuid(current_user_ns(),
le32_to_cpu(super->s_uid));
if (!uid_valid(sbi->s_uid)) {
zonefs_err(sb, "Invalid UID feature\n");
goto unmap;
goto free_page;
}
}

Expand All @@ -1722,7 +1722,7 @@ static int zonefs_read_super(struct super_block *sb)
le32_to_cpu(super->s_gid));
if (!gid_valid(sbi->s_gid)) {
zonefs_err(sb, "Invalid GID feature\n");
goto unmap;
goto free_page;
}
}

Expand All @@ -1731,14 +1731,12 @@ static int zonefs_read_super(struct super_block *sb)

if (memchr_inv(super->s_reserved, 0, sizeof(super->s_reserved))) {
zonefs_err(sb, "Reserved area is being used\n");
goto unmap;
goto free_page;
}

import_uuid(&sbi->s_uuid, super->s_uuid);
ret = 0;

unmap:
kunmap(page);
free_page:
__free_page(page);

Expand Down

0 comments on commit a39b5db

Please sign in to comment.