Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tpm, tpm_tis: Decorate tpm_get_timeouts() with request_locality()
This is shown with Samsung Chromebook Pro (Caroline) with TPM 1.2 (SLB 9670): [ 4.324298] TPM returned invalid status [ 4.324806] WARNING: CPU: 2 PID: 1 at drivers/char/tpm/tpm_tis_core.c:275 tpm_tis_status+0x86/0x8f Background ========== TCG PC Client Platform TPM Profile (PTP) Specification, paragraph 6.1 FIFO Interface Locality Usage per Register, Table 39 Register Behavior Based on Locality Setting for FIFO - a read attempt to TPM_STS_x Registers returns 0xFF in case of lack of locality. The fix ======= Decorate tpm_get_timeouts() with request_locality() and release_locality(). Fixes: a3fbfae ("tpm: take TPM chip power gating out of tpm_transmit()") Cc: James Bottomley <[email protected]> Cc: Guenter Roeck <[email protected]> Cc: Laurent Bigonville <[email protected]> Cc: [email protected] Reported-by: Lukasz Majczak <[email protected]> Signed-off-by: Jarkko Sakkinen <[email protected]>
- Loading branch information