Disable code page write protection in debug mode (flutter#3299)

majido · Dec 8, 2016 · 5afca37 · 5afca37
1 parent 0ebc19c
commit 5afca37
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/runtime/dart_init.cc b/runtime/dart_init.cc
@@ -90,6 +90,10 @@ static const char* kDartBackgroundCompilationArgs[] = {
     "--background_compilation",
 };
 
+static const char* kDartWriteProtectCodeArgs[] = {
+    "--no_write_protect_code",
+};
+
 static const char* kDartCheckedModeArgs[] = {
     // clang-format off
     "--enable_asserts",
@@ -634,6 +638,14 @@ void InitDartVM() {
   const bool use_checked_mode = !IsRunningPrecompiledCode();
 #endif
 
+#if FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_DEBUG
+  // Debug mode uses the JIT, disable code page write protection to avoid
+  // memory page protection changes before and after every compilation.
+  PushBackAll(&args,
+              kDartWriteProtectCodeArgs,
+              arraysize(kDartWriteProtectCodeArgs));
+#endif
+
   if (use_checked_mode)
     PushBackAll(&args, kDartCheckedModeArgs, arraysize(kDartCheckedModeArgs));