a11y improvements for products list section #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radix UI's Checkbox primitive renders a button, which means that instead of `id` and `hmtlFor` the appropriate attribute for a11y is `aria-labelledby`. More info on the Checkbox Pattern [here](https://www.w3.org/WAI/ARIA/apg/patterns/checkbox/).
We were using `asChild` and rendering a `div`. For proper a11y the `div` needed a role of type `button`. Instead, I opted for removing `asChild` since Radix UI uses a button by default for accordion items. I had to tweak some styles to make the button behave like the `div` when it came to its width.
Changing the minimum and maximum values were triggering changes but the intent was that those changes would have to first be applied by clicking the apply button. Furthermore, the logic to determine how to clamp on blur and when to disable the apply button was being applied on the parsed result, causing issues in certain edge cases.
Adds missing label props and ensures heading elements are in a sequentially-descending order.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
migueloller
commented
Dec 31, 2024
| }[colorScheme], | ||
| )} | ||
| /> | ||
| <AccordionsPrimitive.Trigger className="group flex w-full cursor-pointer items-start gap-8 py-3 text-start @md:py-4"> |
There was a problem hiding this comment.
Enable the "Hide whitespace" option for an easier-to-read diff
migueloller
deleted the
miguel/vib-987-fix-a11y-with-soul-productslistsection-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various improvements for the products list section, primarily for a11y.
Once we address color contrast issues we should reach a score of 100.