Skip to content

Commit

Permalink
video: ARM CLCD: Fix DT-related build problems
Browse files Browse the repository at this point in the history
This patch fixes the following error when !CONFIG_OF:

drivers/video/fbdev/amba-clcd.c:800:54: warning: ‘struct amba_dev’ declared inside parameter list [enabled by default]
 static struct clcd_board *clcdfb_of_get_board(struct amba_dev *dev)
                                                      ^
and adds a missing Kconfig select causing this
when CONFIG_OF && !CONFIG_FB_MODE_HELPERS:

drivers/video/fbdev/amba-clcd.c:567: undefined reference to `fb_videomode_from_videomode'

Reported-by: Fengguang Wu <[email protected]>
Signed-off-by: Pawel Moll <[email protected]>
Signed-off-by: Tomi Valkeinen <[email protected]>
pawelmoll authored and tomba committed Aug 4, 2014
1 parent d7aa64c commit 1d5167b
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions drivers/video/fbdev/Kconfig
Original file line number Diff line number Diff line change
@@ -280,6 +280,7 @@ config FB_ARMCLCD
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
select FB_MODE_HELPERS if OF
select VIDEOMODE_HELPERS if OF
help
This framebuffer device driver is for the ARM PrimeCell PL110
2 changes: 1 addition & 1 deletion drivers/video/fbdev/amba-clcd.c
Original file line number Diff line number Diff line change
@@ -797,7 +797,7 @@ static struct clcd_board *clcdfb_of_get_board(struct amba_device *dev)
return board;
}
#else
static struct clcd_board *clcdfb_of_get_board(struct amba_dev *dev)
static struct clcd_board *clcdfb_of_get_board(struct amba_device *dev)
{
return NULL;
}

0 comments on commit 1d5167b

Please sign in to comment.