Skip to content

Commit

Permalink
staging: unisys: Prep for removing 'info' structs
Browse files Browse the repository at this point in the history
The visorbus driver has three _info structs lying around
(device, bus, channel) that store subsets of info from the
bigger structs.

Having these structs around make resource handling very difficult
and more complicated than it needs to be.  Use the device
infrastructure and instead pass 'struct visor_device' all
over the place.

In order to do that 'struct visor_device' needs to get smarter.
This patch adds the pieces to prep for it.  The new elements
will be used in later patches.

Signed-off-by: Don Zickus <[email protected]>
Signed-off-by: Benjamin Romer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
dzickusrh authored and gregkh committed May 24, 2015
1 parent 7957316 commit 1fb3016
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 10 deletions.
19 changes: 19 additions & 0 deletions drivers/staging/unisys/include/visorbus.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,18 @@

struct visor_driver;
struct visor_device;
extern struct bus_type visorbus_type;

typedef void (*visorbus_state_complete_func) (struct visor_device *dev,
int status);
struct visorchipset_state {
u32 created:1;
u32 attached:1;
u32 configured:1;
u32 running:1;
/* Add new fields above. */
/* Remaining bits in this 32-bit word are unused. */
};

/** This struct describes a specific Supervisor channel, by providing its
* GUID, name, and sizes.
Expand Down Expand Up @@ -141,6 +150,16 @@ struct visor_device {
bool resuming;
unsigned long chipset_bus_no;
unsigned long chipset_dev_no;
struct visorchipset_state state;
uuid_le type;
uuid_le inst;
u8 *name;
u8 *description;
struct controlvm_message_header *pending_msg_hdr;
void *vbus_hdr_info;
u32 switch_no;
u32 internal_port_no;
uuid_le partition_uuid;
};

#define to_visor_device(x) container_of(x, struct visor_device, device)
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/unisys/visorbus/visorbus_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const struct attribute_group *visorbus_bus_groups[] = {
/** This describes the TYPE of bus.
* (Don't confuse this with an INSTANCE of the bus.)
*/
static struct bus_type visorbus_type = {
struct bus_type visorbus_type = {
.name = "visorbus",
.match = visorbus_match,
.uevent = visorbus_uevent,
Expand Down
9 changes: 0 additions & 9 deletions drivers/staging/unisys/visorbus/visorbus_private.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,6 @@

struct visorchannel;

struct visorchipset_state {
u32 created:1;
u32 attached:1;
u32 configured:1;
u32 running:1;
/* Add new fields above. */
/* Remaining bits in this 32-bit word are unused. */
};

enum visorchipset_addresstype {
/** address is guest physical, but outside of the physical memory
* region that is controlled by the running OS (this is the normal
Expand Down
4 changes: 4 additions & 0 deletions drivers/staging/unisys/visorbus/visorchannel.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "version.h"
#include "visorbus.h"
#include <linux/uuid.h>
#include "controlvmchannel.h"

#define MYDRVNAME "visorchannel"

Expand All @@ -44,6 +45,9 @@ struct visorchannel {
struct signal_queue_header event_queue;
struct signal_queue_header ack_queue;
} safe_uis_queue;
struct irq_info intr;
uuid_le type;
uuid_le inst;
};

/* Creates the struct visorchannel abstraction for a data area in memory,
Expand Down

0 comments on commit 1fb3016

Please sign in to comment.