netrom: info leak in ->getname()

The sockaddr_ax25 struct has a 3 byte hole between ->sax25_call and ->sax25_ndigis. I've added a memset to avoid leaking uninitialized stack data to userspace. Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Ralf Baechle <[email protected]> Signed-off-by: David S. Miller <[email protected]>
makiko-fly · Apr 25, 2013 · 7a3b684 · 7a3b684
1 parent fccc9f1
commit 7a3b684
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
@@ -834,6 +834,8 @@ static int nr_getname(struct socket *sock, struct sockaddr *uaddr,
 	struct sock *sk = sock->sk;
 	struct nr_sock *nr = nr_sk(sk);
 
+	memset(&sax->fsa_ax25, 0, sizeof(struct sockaddr_ax25));
+
 	lock_sock(sk);
 	if (peer != 0) {
 		if (sk->sk_state != TCP_ESTABLISHED) {