Skip to content

Commit

Permalink
drivers/parisc/pdc_stable.c: use WARN
Browse files Browse the repository at this point in the history
Use WARN rather than printk followed by WARN_ON(1), for conciseness.

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Helge Deller <[email protected]>
  • Loading branch information
JuliaLawall authored and hdeller committed Feb 20, 2013
1 parent 3fad9b8 commit 93c3e91
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/parisc/pdc_stable.c
Original file line number Diff line number Diff line change
@@ -212,12 +212,10 @@ pdcspath_store(struct pdcspath_entry *entry)
entry, devpath, entry->addr);

/* addr, devpath and count must be word aligned */
if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) {
printk(KERN_ERR "%s: an error occurred when writing to PDC.\n"
if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK)
WARN(1, KERN_ERR "%s: an error occurred when writing to PDC.\n"
"It is likely that the Stable Storage data has been corrupted.\n"
"Please check it carefully upon next reboot.\n", __func__);
WARN_ON(1);
}

/* kobject is already registered */
entry->ready = 2;

0 comments on commit 93c3e91

Please sign in to comment.