Skip to content

Commit

Permalink
backlight: ltv350qv: use devm_ functions
Browse files Browse the repository at this point in the history
The devm_ functions allocate memory that is released when a driver
detaches.  This patch uses devm_kzalloc of these functions.

Signed-off-by: Jingoo Han <[email protected]>
Cc: Haavard Skinnemoen <[email protected]>
Cc: Richard Purdie <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Jingoo Han authored and torvalds committed May 29, 2012
1 parent 26f2b35 commit ab03e04
Showing 1 changed file with 7 additions and 16 deletions.
23 changes: 7 additions & 16 deletions drivers/video/backlight/ltv350qv.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,23 +232,20 @@ static int __devinit ltv350qv_probe(struct spi_device *spi)
struct lcd_device *ld;
int ret;

lcd = kzalloc(sizeof(struct ltv350qv), GFP_KERNEL);
lcd = devm_kzalloc(&spi->dev, sizeof(struct ltv350qv), GFP_KERNEL);
if (!lcd)
return -ENOMEM;

lcd->spi = spi;
lcd->power = FB_BLANK_POWERDOWN;
lcd->buffer = kzalloc(8, GFP_KERNEL);
if (!lcd->buffer) {
ret = -ENOMEM;
goto out_free_lcd;
}
lcd->buffer = devm_kzalloc(&spi->dev, 8, GFP_KERNEL);
if (!lcd->buffer)
return -ENOMEM;

ld = lcd_device_register("ltv350qv", &spi->dev, lcd, &ltv_ops);
if (IS_ERR(ld)) {
ret = PTR_ERR(ld);
goto out_free_buffer;
}
if (IS_ERR(ld))
return PTR_ERR(ld);

lcd->ld = ld;

ret = ltv350qv_power(lcd, FB_BLANK_UNBLANK);
Expand All @@ -261,10 +258,6 @@ static int __devinit ltv350qv_probe(struct spi_device *spi)

out_unregister:
lcd_device_unregister(ld);
out_free_buffer:
kfree(lcd->buffer);
out_free_lcd:
kfree(lcd);
return ret;
}

Expand All @@ -274,8 +267,6 @@ static int __devexit ltv350qv_remove(struct spi_device *spi)

ltv350qv_power(lcd, FB_BLANK_POWERDOWN);
lcd_device_unregister(lcd->ld);
kfree(lcd->buffer);
kfree(lcd);

return 0;
}
Expand Down

0 comments on commit ab03e04

Please sign in to comment.