Fix out of range compares on unsigned char archs (powerpc and arm)

malhal · Jul 25, 2021 · d91c24c · d91c24c
1 parent 2a09138
commit d91c24c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/AtomicParsley.h b/src/AtomicParsley.h
@@ -258,7 +258,7 @@ AtomicInfo *APar_UserData_atom_Init(const char *userdata_atom_name,
 
 /* ID3v2 (2.4) style metadata, non-external form */
 AtomicInfo *APar_ID32_atom_Init(const char *frameID_str,
-                                char meta_area,
+                                signed char meta_area,
                                 const char *lang_str,
                                 uint16_t id32_lang);
 

diff --git a/src/parsley.cpp b/src/parsley.cpp
@@ -3561,7 +3561,7 @@ AtomicInfo *APar_reverseDNS_atom_Init(const char *rDNS_atom_name,
 }
 
 AtomicInfo *APar_ID32_atom_Init(const char *frameID_str,
-                                char meta_area,
+                                signed char meta_area,
                                 const char *lang_str,
                                 uint16_t id32_lang) {
   uint8_t total_tracks = 0;