-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding import export session #2
Conversation
Ask chatgpt to write you some tests, usually that gets you 80-90% of the way there. That's what I've been doing and it still catches a bunch of issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git workflow doesn't run pytests, I couldn't get that to work last I tried. You'll have to run pytest locally before pushing. There's a couple other small things in there to address as well.
Also, I realize two of my comments weren't added to the review, but once I added them, I couldn't figure out how to do it without deleting them, so they're not in it technically? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just two small things
should it add users/items in the import when they dont already exist in DB?
should it auto clear on an import?
is 'unique' the correct field to match items?
tested and passing