Fix early exit from validation before all terms are used

[markjfisher]

I'm learning rust, came across your repository and have used it as the basis of my own to learn from.
Thankyou so much for making it public, I'm learning a lot by it.

For Day07, I managed part 1, but part 2 broke me and I looked to your repo for inspiration.

However it didn't work on my Part1 data.
I compared the lines that were different and found that on 2 of my input lines, your code has a false positive.

11174: 15 8 9 79 74
729: 6 6 7 37 650

The valid function is returning a match before it has exhausted all terms. In both cases it finds that the target is reached before considering the first digit in the list (i.e. the final term isn't considered).

I've added a naive simple fix, you may want to make it more compact.

Again many thanks for your repo, it's been an inspiration, as I normally do this in Kotlin, but this year tried to pick up rust again (my second attempt in last few years).

[maneatingape]

Thanks for the analysis and fix!

Was wondering if the input was always structured so that I could wing it using the test_value as a failure, now we know. 🙂

[maneatingape]

Your fix also improved the benchmark from 220 µs to 147 µs. Kudos!

[maneatingape]

Updated my comment in the solution megathread to credit your fix.

You're the first contributor to this repo!