Skip to content

Commit

Permalink
[IOS-123] Apply new information message for transaction fee (KYRDTeam…
Browse files Browse the repository at this point in the history
  • Loading branch information
MrQKyber authored Aug 27, 2020
1 parent 0cefb63 commit 55b206a
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class KConfirmSwapViewController: KNBaseViewController {

self.toTextLabel.text = NSLocalizedString("transaction.to.text", value: "To", comment: "")
self.minAcceptableRateTextLabel.text = NSLocalizedString("min.acceptable.rate", value: "Min Acceptable Rate", comment: "")
self.transactionFeeTextLabel.text = NSLocalizedString("transaction.fee", value: "Transaction Fee", comment: "")
self.transactionFeeTextLabel.text = "Maximum gas fee".toBeLocalised()
self.transactionFeeTextLabel.addLetterSpacing()
self.equivalentUSDValueLabel.text = self.viewModel.displayEquivalentUSDAmount

Expand Down Expand Up @@ -195,9 +195,9 @@ class KConfirmSwapViewController: KNBaseViewController {
@IBAction func helpButtonTapped(_ sender: UIButton) {
KNCrashlyticsUtil.logCustomEvent(withName: "swapconfirm_gas_fee_info_tapped", customAttributes: nil)
self.showBottomBannerView(
message: "Gas.fee.is.the.fee.you.pay.to.the.miner".toBeLocalised(),
message: "The.actual.cost.of.the.transaction.is.generally.lower".toBeLocalised(),
icon: UIImage(named: "help_icon_large") ?? UIImage(),
time: 3
time: 10
)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1332,15 +1332,15 @@ extension KSwapViewController: KAdvancedSettingsViewDelegate {
self.showBottomBannerView(
message: "Gas.fee.is.the.fee.you.pay.to.the.miner".toBeLocalised(),
icon: UIImage(named: "help_icon_large") ?? UIImage(),
time: 3
time: 10
)
case .changeIsUsingReverseRouting(let value):
self.viewModel.isUsingReverseRouting = value
case .reverseRoutingHelpPress:
self.showBottomBannerView(
message: "Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves".toBeLocalised(),
icon: UIImage(named: "help_icon_large") ?? UIImage(),
time: 3
time: 10
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,7 @@ extension KSendTokenViewController: KAdvancedSettingsViewDelegate {
self.showBottomBannerView(
message: "Gas.fee.is.the.fee.you.pay.to.the.miner".toBeLocalised(),
icon: UIImage(named: "help_icon_large") ?? UIImage(),
time: 3
time: 10
)
default: break
}
Expand Down
6 changes: 4 additions & 2 deletions KyberNetwork/Localization/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@

"There.is.a.difference.between.the.estimated.price" = "There is a %@ difference between the estimated price for your swap amount and the reference price.\nNote: Estimated price depends on your swap amount. Reference price is from Chainlink and Kyber Network.";

"Gas.fee.is.the.fee.you.pay.to.the.miner" = "Gas fee is paid to miners (not Kyberswap) to facilitate transactions on the Ethereum blockchain. Generally, the higher the Gas price, the faster your transaction executes. Gas prices depend on how congested the blockchain is, and are not decided by KyberSwap.";
"Gas.fee.is.the.fee.you.pay.to.the.miner" = "Gas fee is the fee you pay to the miner (not to Kyberswap) to mine your transaction on blockchain. The price of gas generally reflect how fast you want a transaction mined.";
"Wallet.must.be.backed.up" = "Please backup your wallet. It will allow you to recover your wallet if your phone is damaged, lost or stolen";
"Later" = "Later";

Expand All @@ -787,5 +787,7 @@
"History" = "History";

"Use reserve routing to enjoy gas savings" = "Use reserve routing to enjoy gas savings";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "Reduce gas costs by routing your trade to predefined reserves. This is the default option for all trades <20 ETH";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "Reduce gas costs by routing your trade to predefined reserves. This is the default option for all trades";
"Reserve routing is used in this transaction to reduce gas costs" = "Reserve routing is used in this transaction to reduce gas costs";
"Maximum gas fee" = "Maximum gas fee";
"The.actual.cost.of.the.transaction.is.generally.lower" = "The actual cost of the transaction is generally lower than the maximum estimated cost.";
7 changes: 5 additions & 2 deletions KyberNetwork/Localization/ko.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@

"There.is.a.difference.between.the.estimated.price" = "교환하려는 토큰 양에 대한 추정 가격과 참고 가격 간 차이가 %@ 입니다.\n주의: 추정 가격은 교환하려는 토큰 양에 따라 다릅니다. 참고 가격은 Kyber Network와 Chainlink에서 가져옵니다.";

"Gas.fee.is.the.fee.you.pay.to.the.miner" = "가스비는 블록체인에서 거래를 채굴하기 위해 (카이버 스왑이 아닌) 채굴자에게 지불되는 비용입니다. 보통 가스의 가격은 원하는 거래 속도에 비례하여 반영됩니다.";
"Gas.fee.is.the.fee.you.pay.to.the.miner" = "가스비는 (카이버 스왑이 아닌) 블록체인 상의 트랜잭션을 채굴하는 채굴자에게 지불하는 비용입니다. 가스의 가격은 보통 얼마나 빠르게 트랜잭션이 채굴되기 원하는 지에 따라 책정됩니다.";
"Wallet.must.be.backed.up" = "지갑을 다른 곳에 백업해 주세요. 지갑이 백업되어 있으면 핸드폰의 고장, 분실, 도난의 경우 복원이 가능합니다.";
"Later" = "나중에";

Expand All @@ -789,5 +789,8 @@
"History" = "거래내역";

"Use reserve routing to enjoy gas savings" = "가스비 절약을 위해 리저브 라우팅을 사용하세요";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "미리 지정된 리저브로 거래를 라우팅하여 가스비를 절감하세요. 20이더 미만의 거래는 해당 옵션이 기본적으로 적용됩니다.";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = " 미리 지정된 리저브에 거래를 라우팅 시킴으로서 가스비를 줄일 수 있습니다. 이 옵션은 모든 거래에 기본으로 설정됩니다.";
"Reserve routing is used in this transaction to reduce gas costs" = "가스비 절감을 위해 당 거래에서는 리저브 라우팅이 사용됩니다.";

"Maximum gas fee" = "최대 가스비";
"The.actual.cost.of.the.transaction.is.generally.lower" = "트랜잭션의 실제 비용은 보통 최대치로 계산된 비용보다 낮습니다.";
4 changes: 3 additions & 1 deletion KyberNetwork/Localization/vi.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -789,5 +789,7 @@
"History" = "Lịch sử";

"Use reserve routing to enjoy gas savings" = "Sử dụng Reserve routing để giảm thiểu phí gas";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "Giảm phí gas bằng cách giao dịch với các quỹ được chọn trước. Đây là tùy chọn mặc định cho các giao dịch < 20 ETH";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "Giảm chi phí gas bằng cách giao dịch với các quỹ dự trữ được chọn sẵn. Đây là bước mặc định cho mọi giao dịch";
"Reserve routing is used in this transaction to reduce gas costs" = "Reserve routing được sử dụng trong giao dịch này để giảm phí gas";
"Maximum gas fee" = "Phí gas tối đa";
"The.actual.cost.of.the.transaction.is.generally.lower" = "Chi phí thực tế của giao dịch thông thường sẽ thấp hơn chi phí ước tính tối đa.";
6 changes: 4 additions & 2 deletions KyberNetwork/Localization/zh-Hans.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@

"There.is.a.difference.between.the.estimated.price" = "您要的兑换金额的估计价格与参考价格之间存在%@的差异。\n请注意:估计价格取决于您的兑换金额。参考价格来自Chainlink和Kyber Network。";

"Gas.fee.is.the.fee.you.pay.to.the.miner" = "燃料费用费是您支付给矿工(而不是支付给KyberSwap)以在区块链上进行交易的费用。燃料的价格通常反映了您希望一笔交易的开采速度有多快。";
"Gas.fee.is.the.fee.you.pay.to.the.miner" = "Gas费用是您支付给矿工的费用(并非Kyberswap),以在区块链上进行交易。 gas费用的高低反映了交易打包出块的优先级。";
"Wallet.must.be.backed.up" = "请备份您的钱包。以便在手机发生损坏、丢失或被盗的情况下,能帮助您找回钱包.";
"Later" = "以后";

Expand All @@ -789,5 +789,7 @@
"History" = "历史纪录";

"Use reserve routing to enjoy gas savings" = "使用储备库路由来节省gas费用";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "通过将您的交易发送到预定义的储备库来降低gas费用。这是所有小于20 ETH交易的默认选项";
"Reduce.gas.costs.by.routing.your.trade.to.predefined.reserves" = "通过将您的交易发送到预定义的储备库来降低gas费用。这是所有交易的默认选项。";
"Reserve routing is used in this transaction to reduce gas costs" = "在该笔交易中使用储备库路由来降低gas费用";
"Maximum gas fee" = "最高的gas费用。";
"The.actual.cost.of.the.transaction.is.generally.lower" = "交易的实际费用一般低于最高估计费用。";

0 comments on commit 55b206a

Please sign in to comment.