- fixed incorrect calculation of recording length, changed int dataty…

…pe to long in RecordingService.java to properly calculate System.CurrentTimeMillis()
maniacs-m · Jan 15, 2015 · 1ffa89a · 1ffa89a
1 parent 622c1ad
commit 1ffa89a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -8,8 +8,8 @@ android {
         applicationId "com.danielkim.soundrecorder"
         minSdkVersion 16
         targetSdkVersion 21
-        versionCode 4
-        versionName "1.2.1"
+        versionCode 5
+        versionName "1.2.2"
     }
     buildTypes {
         release {

diff --git a/app/src/main/java/com/danielkim/soundrecorder/RecordingService.java b/app/src/main/java/com/danielkim/soundrecorder/RecordingService.java
@@ -37,7 +37,7 @@ public class RecordingService extends Service {
     private DBHelper mDatabase;
 
     private long mStartingTimeMillis = 0;
-    private int mElapsedMillis = 0;
+    private long mElapsedMillis = 0;
     private int mElapsedSeconds = 0;
     private OnTimerChangedListener onTimerChangedListener = null;
     private static final SimpleDateFormat mTimerFormat = new SimpleDateFormat("mm:ss", Locale.getDefault());
@@ -116,7 +116,7 @@ public void setFileNameAndPath(){
 
     public void stopRecording() {
         mRecorder.stop();
-        mElapsedMillis = (int) (System.currentTimeMillis() - mStartingTimeMillis);
+        mElapsedMillis = (System.currentTimeMillis() - mStartingTimeMillis);
         mRecorder.release();
         Toast.makeText(this, getString(R.string.toast_recording_finish) + " " + mFilePath, Toast.LENGTH_LONG).show();
 

diff --git a/app/src/main/java/com/danielkim/soundrecorder/adapters/FileViewerAdapter.java b/app/src/main/java/com/danielkim/soundrecorder/adapters/FileViewerAdapter.java
@@ -62,7 +62,7 @@ public void onBindViewHolder(final RecordingsViewHolder holder, int position) {
                 - TimeUnit.MINUTES.toSeconds(minutes);
 
         holder.vName.setText(item.getName());
-        holder.vLength.setText(String.format("%02d:%02d", minutes,seconds));
+        holder.vLength.setText(String.format("%02d:%02d", minutes, seconds));
         holder.vDateAdded.setText(mDateAddedFormatter.format(item.getTime()));
 
         // define an on click listener to open PlaybackFragment

diff --git a/app/src/main/java/com/danielkim/soundrecorder/fragments/PlaybackFragment.java b/app/src/main/java/com/danielkim/soundrecorder/fragments/PlaybackFragment.java
@@ -307,7 +307,7 @@ public void run() {
                 long minutes = TimeUnit.MILLISECONDS.toMinutes(mCurrentPosition);
                 long seconds = TimeUnit.MILLISECONDS.toSeconds(mCurrentPosition)
                         - TimeUnit.MINUTES.toSeconds(minutes);
-                mCurrentProgressTextView.setText(String.format("%02d:%02d", minutes,seconds));
+                mCurrentProgressTextView.setText(String.format("%02d:%02d", minutes, seconds));
 
                 updateSeekBar();
             }