Correct nullability for FlutterStandardReader (flutter#8537)

FlutterStandardReader's `readValueOfType:` method returns nil when called with `FlutterStandardFieldNil`. By extension, `readValue` can also return nil values.
manikm · Apr 11, 2019 · f53e477 · f53e477
1 parent c00364a
commit f53e477
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/shell/platform/darwin/ios/framework/Headers/FlutterCodecs.h b/shell/platform/darwin/ios/framework/Headers/FlutterCodecs.h
@@ -116,8 +116,8 @@ FLUTTER_EXPORT
 - (UInt32)readSize;
 - (void)readAlignment:(UInt8)alignment;
 - (NSString*)readUTF8;
-- (id)readValue;
-- (id)readValueOfType:(UInt8)type;
+- (nullable id)readValue;
+- (nullable id)readValueOfType:(UInt8)type;
 @end
 
 /**

diff --git a/shell/platform/darwin/ios/framework/Source/FlutterStandardCodec.mm b/shell/platform/darwin/ios/framework/Source/FlutterStandardCodec.mm
@@ -408,11 +408,11 @@ - (FlutterStandardTypedData*)readTypedDataOfType:(FlutterStandardDataType)type {
   return [FlutterStandardTypedData typedDataWithData:data type:type];
 }
 
-- (id)readValue {
+- (nullable id)readValue {
   return [self readValueOfType:[self readByte]];
 }
 
-- (id)readValueOfType:(UInt8)type {
+- (nullable id)readValueOfType:(UInt8)type {
   FlutterStandardField field = (FlutterStandardField)type;
   switch (field) {
     case FlutterStandardFieldNil: