fix(createUseStorageState): invoke setState twice (alibaba#2532)

mannix-lei · Apr 25, 2024 · 4841696 · 4841696
1 parent 3ba7cb6
commit 4841696
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/hooks/src/createUseStorageState/index.ts b/packages/hooks/src/createUseStorageState/index.ts
@@ -70,7 +70,10 @@ export function createUseStorageState(getStorage: () => Storage | undefined) {
 
     const updateState = (value?: SetState<T>) => {
       const currentState = isFunction(value) ? value(state) : value;
-      setState(currentState);
+
+      if (!listenStorageChange) {
+        setState(currentState);
+      }
 
       try {
         let newValue: string | null;
@@ -126,5 +129,6 @@ export function createUseStorageState(getStorage: () => Storage | undefined) {
 
     return [state, useMemoizedFn(updateState)] as const;
   }
+
   return useStorageState;
 }
diff --git a/packages/hooks/src/useLocalStorageState/demo/demo4.tsx b/packages/hooks/src/useLocalStorageState/demo/demo4.tsx
@@ -24,15 +24,12 @@ function Counter() {
     listenStorageChange: true,
   });
 
-  const add = () => setCount(count! + 1);
-  const clear = () => setCount();
-
   return (
     <div style={{ marginBottom: '8px' }}>
-      <button style={{ marginRight: '8px' }} onClick={add}>
+      <button style={{ marginRight: '8px' }} onClick={() => setCount(count! + 1)}>
         count: {count}
       </button>
-      <button onClick={clear}>Clear</button>
+      <button onClick={() => setCount()}>Clear</button>
     </div>
   );
 }