-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Halo install requires UTF-8 locale to be set #125
Conversation
Pull Request Test Coverage Report for Build 370
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 370
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 Thanks @adamtheturtle and really apologize for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 Thanks @adamtheturtle and really apologize for the delay!
I think my fix still has something you need - it ensures the README is opened read-only, which is missing from the old code and #125 Thanks for sorting it out anyway! |
@juledwar Ah, makes sense. I'll make that change in some time. For now, I've made the release for this. |
@manrajgrover Thanks! Is there any chance you can release log-symbols 0.0.13 as well and release Halo again to use it? It has the important enum34 fix! |
@juledwar Looking into it. Thanks for pointing it out. I've been a lot occupied lately and had decided to squash and sort out everything today. 😄 |
@juledwar Made a release and updated halo to v0.0.25! This should be fixed now. |
Description of new feature, or changes
See #124 for the issue that this fixes.
This change has been tested with the test set out in that issue.
Checklist
Related Issues and Discussions
Fixes #124 .
People to notify
@manrajgrover