Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Halo install requires UTF-8 locale to be set #125

Merged
merged 2 commits into from
May 29, 2019

Conversation

adamtheturtle
Copy link
Contributor

Description of new feature, or changes

See #124 for the issue that this fixes.
This change has been tested with the test set out in that issue.

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature: This is not a new feature.
  • All tests are passing: I hope they will!

Related Issues and Discussions

Fixes #124 .

People to notify

@manrajgrover

@coveralls
Copy link

Pull Request Test Coverage Report for Build 370

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.5%) to 88.689%

Files with Coverage Reduction New Missed Lines %
halo/halo.py 2 91.97%
halo/_utils.py 4 70.49%
Totals Coverage Status
Change from base Build 355: -1.5%
Covered Lines: 283
Relevant Lines: 313

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 370

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.5%) to 88.689%

Files with Coverage Reduction New Missed Lines %
halo/halo.py 2 91.97%
halo/_utils.py 4 70.49%
Totals Coverage Status
Change from base Build 355: -1.5%
Covered Lines: 283
Relevant Lines: 313

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 2, 2019

Pull Request Test Coverage Report for Build 371

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.231%

Totals Coverage Status
Change from base Build 355: 0.0%
Covered Lines: 289
Relevant Lines: 313

💛 - Coveralls

Copy link
Owner

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Thanks @adamtheturtle and really apologize for the delay!

Copy link
Owner

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Thanks @adamtheturtle and really apologize for the delay!

@juledwar
Copy link

I think my fix still has something you need - it ensures the README is opened read-only, which is missing from the old code and #125

Thanks for sorting it out anyway!

@manrajgrover
Copy link
Owner

@juledwar Ah, makes sense. I'll make that change in some time. For now, I've made the release for this.

https://pypi.org/project/halo/0.0.24/

@juledwar
Copy link

@manrajgrover Thanks! Is there any chance you can release log-symbols 0.0.13 as well and release Halo again to use it? It has the important enum34 fix!

@manrajgrover
Copy link
Owner

@juledwar Looking into it. Thanks for pointing it out. I've been a lot occupied lately and had decided to squash and sort out everything today. 😄

@manrajgrover
Copy link
Owner

@juledwar Made a release and updated halo to v0.0.25! This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Halo install requires UTF-8 locale to be set
4 participants