some tweaks for TileLayer performance #2516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzhenn
requested changes
Mar 20, 2025
| const terrainTileMode = layer._isPyramidMode() && layer.options['terrainTileMode']; | ||
| let tileGrids = layer.getTiles(); | ||
| this._frameTileGrids = tileGrids; | ||
| tileGrids = tileGrids.tileGrids; | ||
| if (!tileGrids || !tileGrids.length) { | ||
| layer._tempSr = null; |
There was a problem hiding this comment.
layer._tempSr和this._tempMap可以改名为 layer._spatialRef 和 this.map
因为虽然目的是为了临时设置变量，以减少函数调用，但这两个变量实际上并不是临时的，而确实是他们所拥有的空间参考和所属的map，也不是临时用完就没用了的，在含义上还叫temp并不准确。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2515