Skip to content

Commit

Permalink
ovn-northd: Fix parsing of load balance keys.
Browse files Browse the repository at this point in the history
The OVN load balance tests are failing in both kernel and userspace DP.
The problem is due to bad parsing of the load balance keys because of
using the wrong default port mode in the call to inet_parse_active().

With this fix, the tests are now passing again.

system-ovn

100: ovn -- load-balancing                           ok
101: ovn -- load-balancing - same subnet.            ok
102: ovn -- load balancing in gateway router         ok
103: ovn -- multiple gateway routers, load-balancing ok
104: ovn -- load balancing in router with gateway router port ok

Signed-off-by: Darrell Ball <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
Acked-by: Mark Michelson <[email protected]>
  • Loading branch information
darball1 authored and blp committed May 9, 2018
1 parent 2853368 commit d261aef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ovn/northd/ovn-northd.c
Original file line number Diff line number Diff line change
Expand Up @@ -2942,7 +2942,7 @@ ip_address_and_port_from_lb_key(const char *key, char **ip_address,
uint16_t *port, int *addr_family)
{
struct sockaddr_storage ss;
if (!inet_parse_active(key, -1, &ss)) {
if (!inet_parse_active(key, 0, &ss)) {
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);
VLOG_WARN_RL(&rl, "bad ip address or port for load balancer key %s",
key);
Expand Down

0 comments on commit d261aef

Please sign in to comment.