ovn-controller(8): ovn-remote must be an ovsdb remote.

Document that the value of the ovn-remote configuration option must be in the form of an ovsdb remote as previously documented in this man page. This came up on IRC where someone trying OVN put a hostname here and observed that it did not work. Signed-off-by: Russell Bryant <[email protected]> Acked-by: Ben Pfaff <[email protected]>
marbindrakon · Dec 6, 2016 · ff956ea · ff956ea
1 parent 8b6987d
commit ff956ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml
@@ -93,13 +93,8 @@
       <dd>
         <p>
           The OVN database that this system should connect to for its
-          configuration.
-        </p>
-
-        <p>
-          Currently, <code>ovn-controller</code> does not support changing this
-          setting mid-run.  If the value needs to change, the daemon must be
-          restarted.  (This behavior should be improved.)
+          configuration, in one of the same forms documented above for the
+          <var>ovs-database</var>.
         </p>
       </dd>
 

diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c
@@ -204,10 +204,7 @@ get_chassis_id(const struct ovsdb_idl *ovs_idl)
 }
 
 /* Retrieves the OVN Southbound remote location from the
- * "external-ids:ovn-remote" key in 'ovs_idl' and returns a copy of it.
- *
- * XXX ovn-controller does not support this changing mid-run, but that should
- * be addressed later. */
+ * "external-ids:ovn-remote" key in 'ovs_idl' and returns a copy of it. */
 static char *
 get_ovnsb_remote(struct ovsdb_idl *ovs_idl)
 {