Fix eslint warnings

The @typescript-eslint/no-unused-vars rule allows unused arguments in functions only if prefix with a '_'. Closed eclipse-cdt-cloud#83 Signed-off-by: Geneviève Bastien <[email protected]>
marcdumais-work · Jul 7, 2020 · 6b428f8 · 6b428f8
1 parent 2d28f10
commit 6b428f8
Show file tree

Hide file tree

Showing 23 changed files with 50 additions and 45 deletions.
diff --git a/configs/warnings.eslintrc.json b/configs/warnings.eslintrc.json
@@ -2,6 +2,7 @@
   "rules": {
     "@typescript-eslint/await-thenable": "warn",
     "no-return-await": "warn",
-    "keyword-spacing": ["warn", { "before": true, "after": true} ]
+    "keyword-spacing": ["warn", { "before": true, "after": true} ],
+    "@typescript-eslint/no-unused-vars": ["warn", { "vars": "all", "args": "after-used", "argsIgnorePattern": "^_" }]
   }
 }
diff --git a/viewer-prototype/src/browser/trace-explorer/trace-explorer-widget.tsx b/viewer-prototype/src/browser/trace-explorer/trace-explorer-widget.tsx
@@ -74,7 +74,7 @@ export class TraceExplorerWidget extends ReactWidget {
         this.updateAvailableAnalysis(openedExperiment);
     }
 
-    private onExperimentClosed(closedExperiment: Experiment) {
+    private onExperimentClosed(_closedExperiment: Experiment) {
         this.tooltip = {};
         this.updateOpenedExperiments();
         this.updateAvailableAnalysis(undefined);

diff --git a/viewer-prototype/src/browser/trace-viewer/components/abstract-output-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/abstract-output-component.tsx
@@ -39,7 +39,7 @@ export abstract class AbstractOutputComponent<P extends AbstractOutputProps, S e
         this.mainAreaContainer = React.createRef();
     }
 
-    render() {
+    render(): JSX.Element {
         this.closeComponent = this.closeComponent.bind(this);
         return <div className='output-container' style={{ width: this.props.style.width }}>
             <div className='widget-handle' style={{ width: this.handleWidth }}>

diff --git a/viewer-prototype/src/browser/trace-viewer/components/abstract-tree-output-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/abstract-tree-output-component.tsx
@@ -9,7 +9,7 @@ export abstract class AbstractTreeOutputComponent<P extends AbstractOutputProps,
         const treeWidth = this.props.style.width - this.props.style.chartWidth - this.getHandleWidth();
         return <React.Fragment>
             <div ref={this.treeRef} className='output-component-tree'
-                onScroll={ev => { this.synchronizeTreeScroll(); }}
+                onScroll={_ev => { this.synchronizeTreeScroll(); }}
                 style={{ width: treeWidth, height: this.props.style.height }}
             >
                 {this.renderTree()}
@@ -28,7 +28,7 @@ export abstract class AbstractTreeOutputComponent<P extends AbstractOutputProps,
 
     abstract synchronizeTreeScroll(): void;
 
-    protected async waitAnalysisCompletion() {
+    protected async waitAnalysisCompletion(): Promise<void> {
         const traceUUID = this.props.traceId;
         const tspClient = this.props.tspClient;
         const outPutId = this.props.outputDescriptor.id;
@@ -45,9 +45,9 @@ export abstract class AbstractTreeOutputComponent<P extends AbstractOutputProps,
         });
     }
 
-    componentWillUnmount() {
+    componentWillUnmount(): void {
         // fix Warning: Can't perform a React state update on an unmounted component
-        this.setState = (state,callback) => undefined;
+        this.setState = (_state, _callback) => undefined;
 
     }
 }
diff --git a/viewer-prototype/src/browser/trace-viewer/components/data-providers/style-provider.ts b/viewer-prototype/src/browser/trace-viewer/components/data-providers/style-provider.ts
@@ -93,7 +93,7 @@ export class StyleProvider {
         return this.styles;
     }
 
-    public getStylesTmp(forceUpdate?: boolean): { [key: string]: { [key: string]: any } } {
+    public getStylesTmp(_forceUpdate?: boolean): { [key: string]: { [key: string]: any } } {
         const styles = this.tmpStyleObject[this.outputId];
         return styles ? styles : {};
     }

diff --git a/viewer-prototype/src/browser/trace-viewer/components/data-providers/tsp-data-provider.ts b/viewer-prototype/src/browser/trace-viewer/components/data-providers/tsp-data-provider.ts
@@ -97,7 +97,7 @@ export class TspDataProvider {
         this.timeGraphRows = newTimeGraphRows;
     }
 
-    protected getStateModelByRow(row: TimeGraphRow, chartStart: number) {
+    protected getStateModelByRow(row: TimeGraphRow, chartStart: number): TimelineChart.TimeGraphRowElementModel[] {
         const states: TimelineChart.TimeGraphRowElementModel[] = [];
         row.states.forEach((state: TimeGraphState, idx: number) => {
             const end = state.startTime + state.duration - chartStart;

diff --git a/viewer-prototype/src/browser/trace-viewer/components/timegraph-output-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/timegraph-output-component.tsx
@@ -86,11 +86,11 @@ export class TimegraphOutputComponent extends AbstractTreeOutputComponent<Timegr
         }
     }
 
-    async componentDidMount() {
+    async componentDidMount(): Promise<void> {
         this.waitAnalysisCompletion();
     }
 
-    async componentDidUpdate(prevProps: TimegraphOutputProps, prevState: TimegraohOutputState) {
+    async componentDidUpdate(_prevProps: TimegraphOutputProps, _prevState: TimegraohOutputState):  Promise<void> {
         if (this.state.outputStatus !== ResponseStatus.COMPLETED || !this.state.timegraphTree.length) {
             const treeParameters = QueryHelper.timeQuery([0, 1]);
             const treeResponse = (await this.props.tspClient.fetchTimeGraphTree<TimeGraphEntry, EntryHeader>(this.props.traceId,
@@ -161,7 +161,7 @@ export class TimegraphOutputComponent extends AbstractTreeOutputComponent<Timegr
         </ReactTimeGraphContainer>;
     }
 
-    protected getVerticalScrollbar() {
+    protected getVerticalScrollbar(): JSX.Element {
         return <ReactTimeGraphContainer
             id='vscroll'
             options={{

diff --git a/viewer-prototype/src/browser/trace-viewer/components/trace-context-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/trace-context-component.tsx
@@ -52,7 +52,7 @@ export class TraceContextComponent extends React.Component<TraceContextProps, Tr
     private traceContextContainer: React.RefObject<HTMLDivElement>;
 
     protected widgetResizeHandlers: (() => void)[] = [];
-    protected readonly addWidgetResizeHandler = (h: () => void) => {
+    protected readonly addWidgetResizeHandler = (h: () => void): void => {
         this.widgetResizeHandlers.push(h);
     };
 
@@ -124,7 +124,7 @@ export class TraceContextComponent extends React.Component<TraceContextProps, Tr
                     text: `Indexing ${this.props.experiment.name}: ${this.state.experiment.nbEvents}`,
                     alignment: StatusBarAlignment.RIGHT
                 });
-                await this.sleep(500);
+                this.sleep(500);
             }
         }
         this.props.statusBar.removeElement(this.INDEXING_STATUS_BAR_KEY);
@@ -134,13 +134,13 @@ export class TraceContextComponent extends React.Component<TraceContextProps, Tr
         new Promise(resolve => setTimeout(resolve, ms));
     }
 
-    componentDidMount() {
+    componentDidMount(): void {
         this.onResize = this.onResize.bind(this);
         this.props.addResizeHandler(this.onResize);
         this.onResize();
     }
 
-    componentWillUnmount() {
+    componentWillUnmount(): void {
         this.props.statusBar.removeElement(this.INDEXING_STATUS_BAR_KEY);
         this.props.statusBar.removeElement(this.TIME_SELECTION_STATUS_BAR_KEY);
     }
@@ -174,7 +174,7 @@ export class TraceContextComponent extends React.Component<TraceContextProps, Tr
             }));
     }
 
-    render() {
+    render(): JSX.Element {
         return <div className='trace-context-container' ref={this.traceContextContainer}>
             {this.props.outputs.length ? this.renderOutputs() : this.renderPlaceHolder()}
         </div>;

diff --git a/...r-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/checkbox-component.tsx b/...r-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/checkbox-component.tsx
@@ -13,7 +13,7 @@ export class CheckboxComponent extends React.Component<CheckboxProps> {
         super(props);
     }
 
-    renderCheckbox = (checkedStatus: number) => {
+    renderCheckbox = (checkedStatus: number): React.ReactNode => {
         switch (checkedStatus) {
             case 0:
                 return icons.unchecked;
@@ -26,7 +26,7 @@ export class CheckboxComponent extends React.Component<CheckboxProps> {
         }
     };
 
-    render() {
+    render(): JSX.Element {
         return <div onClick={() => this.props.onChecked(this.props.id)} >
             <span style={{padding: 5}}>
                 {this.renderCheckbox(this.props.checkedStatus)}

diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/message.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/message.tsx
@@ -13,7 +13,7 @@ export class Message extends React.Component<MessageProps> {
         error: ''
     };
 
-    render() {
+    render(): JSX.Element {
         return <React.Fragment>
             <span>{this.props.error}</span>
         </React.Fragment>;

diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/tree.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/tree.tsx
@@ -28,8 +28,12 @@ export class FilterTree extends React.Component<FilterTreeProps> {
 
     getNode = (id: number): TreeNode | undefined => {
         const nodes: TreeNode[] = [...this.props.nodes];
+        if (!nodes) {
+            return undefined;
+        }
         let currentNode: TreeNode;
         while (nodes.length) {
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             currentNode = nodes.pop()!;
             if (currentNode.id === id) {
                 return currentNode;
@@ -114,7 +118,7 @@ export class FilterTree extends React.Component<FilterTreeProps> {
 
     isCollapsed = (id: number): boolean => this.props.collapsedNodes.includes(id);
 
-    renderTreeNodes = (nodes: TreeNode[], parent: TreeNode = defaultTreeNode, level = 0): JSX.Element | undefined => {
+    renderTreeNodes = (nodes: TreeNode[], _parent: TreeNode = defaultTreeNode, level = 0): JSX.Element | undefined => {
         const treeNodes = nodes.map((node: TreeNode) => {
             const children = node.children.length > 0 ? this.renderTreeNodes(node.children, node, level+1) : undefined;
             const checkedStatus = this.getCheckedStatus(node.id);

diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/utils.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/utils.tsx
@@ -10,7 +10,7 @@ const entryToTreeNode = (entry: Entry) => ({
         children: []
     } as TreeNode);
 
-export const listToTree = (list: Entry[]) => {
+export const listToTree = (list: Entry[]): TreeNode[] => {
     const rootNodes: TreeNode[] = [];
     const lookup: { [key: string]: TreeNode } = {};
     list.forEach(entry => {

diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/xy-tree.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/filtrer-tree/xy-tree.tsx
@@ -16,9 +16,9 @@ export class XYTree extends React.Component<XYTreeProps> {
         super(props);
     }
 
-    shouldComponentUpdate = (nextProps: XYTreeProps) => (this.props.checkedSeries !== nextProps.checkedSeries || this.props.entries !== nextProps.entries);
+    shouldComponentUpdate = (nextProps: XYTreeProps): boolean => (this.props.checkedSeries !== nextProps.checkedSeries || this.props.entries !== nextProps.entries);
 
-    render() {
+    render(): JSX.Element {
         return <FilterTree
             nodes = { listToTree(this.props.entries) }
             showCheckboxes={true}

diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/time-axis-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/time-axis-component.tsx
@@ -16,7 +16,7 @@ interface TimeAxisProps {
 }
 
 export class TimeAxisComponent extends React.Component<TimeAxisProps> {
-    render() {
+    render(): JSX.Element {
         return <ReactTimeGraphContainer
             id='timegraph-axis'
             options={{
@@ -31,15 +31,15 @@ export class TimeAxisComponent extends React.Component<TimeAxisProps> {
             layer={[this.getAxisLayer(), this.getAxisCursors()]} />;
     }
 
-    protected getAxisLayer() {
+    protected getAxisLayer(): TimeGraphAxis {
         const timeAxisLayer = new TimeGraphAxis('timeGraphAxis', {
             color: this.props.style.naviBackgroundColor,
             lineColor: this.props.style.lineColor
         });
         return timeAxisLayer;
     }
 
-    protected getAxisCursors() {
+    protected getAxisCursors(): TimeGraphAxisCursors {
         return new TimeGraphAxisCursors('timeGraphAxisCursors', { color: this.props.style.cursorColor });
     }
 }
diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/time-navigator-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/time-navigator-component.tsx
@@ -15,7 +15,7 @@ interface TimeNavigatorProps {
 }
 
 export class TimeNavigatorComponent extends React.Component<TimeNavigatorProps> {
-    render() {
+    render(): JSX.Element {
         const navi = new TimeGraphNavigator('timeGraphNavigator');
         return <ReactTimeGraphContainer
             id='time-navigator'

diff --git a/viewer-prototype/src/browser/trace-viewer/components/utils/timegraph-container-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/utils/timegraph-container-component.tsx
@@ -17,7 +17,7 @@ export class ReactTimeGraphContainer extends React.Component<ReactTimeGraphConta
     protected ref: HTMLCanvasElement | undefined;
     protected container?: TimeGraphContainer;
 
-    componentDidMount() {
+    componentDidMount(): void {
         this.container = new TimeGraphContainer(this.props.options, this.props.unitController, this.ref);
         this.props.layer.forEach(l => {
             if (this.container) { this.container.addLayer(l); }
@@ -28,7 +28,7 @@ export class ReactTimeGraphContainer extends React.Component<ReactTimeGraphConta
         });
     }
 
-    render() {
+    render(): JSX.Element {
         return <canvas ref={ref => this.ref = ref || undefined} onWheel={e => e.preventDefault()}></canvas>;
     }
 }
diff --git a/viewer-prototype/src/browser/trace-viewer/components/xy-output-component.tsx b/viewer-prototype/src/browser/trace-viewer/components/xy-output-component.tsx
@@ -37,18 +37,18 @@ export class XYOutputComponent extends AbstractTreeOutputComponent<AbstractOutpu
 
         this.afterChartDraw = this.afterChartDraw.bind(this);
         Chart.pluginService.register({
-            afterDraw: (chart, easing) => {
+            afterDraw: (chart, _easing) => {
                 this.afterChartDraw(chart);
             }
         });
         this.lineChartRef = React.createRef();
     }
 
-    componentDidMount() {
+    componentDidMount(): void {
         this.waitAnalysisCompletion();
     }
 
-    componentDidUpdate(prevProps: AbstractOutputProps, prevState: XYOuputState) {
+    componentDidUpdate(prevProps: AbstractOutputProps, prevState: XYOuputState): void {
         const viewRangeChanged = this.props.viewRange !== prevProps.viewRange;
         const checkedSeriesChanged = this.state.checkedSeries !== prevState.checkedSeries;
         const collapsedNodesChanged = this.state.collapsedNodes !== prevState.collapsedNodes;

diff --git a/viewer-prototype/src/browser/trace-viewer/trace-viewer-contribution.ts b/viewer-prototype/src/browser/trace-viewer/trace-viewer-contribution.ts
@@ -26,7 +26,7 @@ export class TraceViewerContribution extends WidgetOpenHandler<TraceViewerWidget
         registry.registerCommand(TraceViewerCommands.OPEN);
     }
 
-    canHandle(uri: URI): number {
+    canHandle(_uri: URI): number {
         return 100;
     }
 }
diff --git a/viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx b/viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx
@@ -86,7 +86,7 @@ export class TraceViewerWidget extends ReactWidget {
         this.update();
     }
 
-    onCloseRequest(msg: Message) {
+    onCloseRequest(msg: Message): void {
         if (this.openedExperiment) {
 
             const traces = this.openedExperiment.traces;
@@ -107,7 +107,7 @@ export class TraceViewerWidget extends ReactWidget {
         super.onCloseRequest(msg);
     }
 
-    protected onResize() {
+    protected onResize(): void {
         this.resizeHandlers.forEach(h => h());
     }
 

diff --git a/viewer-prototype/src/common/experiment-manager.ts b/viewer-prototype/src/common/experiment-manager.ts
@@ -96,7 +96,7 @@ export class ExperimentManager {
             // Repost with a suffix as long as there are conflicts
             const handleConflict = async function (tspClient: TspClient, tryNb: number): Promise<TspClientResponse<Experiment>> {
                 const suffix = '(' + tryNb + ')';
-                return await tspClient.createExperiment(new Query({
+                return tspClient.createExperiment(new Query({
                     'name': name + suffix,
                     'traces': traceURIs
                 }));
@@ -141,7 +141,7 @@ export class ExperimentManager {
      * Close the given on the server
      * @param experimentUUID experiment UUID
      */
-    async closeExperiment(experimentUUID: string) {
+    async closeExperiment(experimentUUID: string): Promise<void> {
         const experimentToClose = this.fOpenExperiments.get(experimentUUID);
         if (experimentToClose) {
             await this.tspClient.deleteExperiment(experimentUUID);

diff --git a/viewer-prototype/src/common/signal-manager.ts b/viewer-prototype/src/common/signal-manager.ts
@@ -18,7 +18,7 @@ export class SignalManager {
         return this.instance;
     }
 
-    public fireTooltipSignal(payload: { [key: string]: string }) {
+    public fireTooltipSignal(payload: { [key: string]: string }): void {
         this.tooltipEmitter.fire(payload);
     }
 }
diff --git a/viewer-prototype/src/common/trace-manager.ts b/viewer-prototype/src/common/trace-manager.ts
@@ -94,7 +94,7 @@ export class TraceManager {
             // Repost with a suffix as long as there are conflicts
             const handleConflict = async function (tspClient: TspClient, tryNb: number): Promise<TspClientResponse<Trace>> {
                 const suffix = '(' + tryNb + ')';
-                return await tspClient.openTrace(new Query({
+                return tspClient.openTrace(new Query({
                     'name': name + suffix,
                     'uri': tracePath
                 }));
@@ -139,7 +139,7 @@ export class TraceManager {
      * Close the given on the server
      * @param traceUUID Trace UUID
      */
-    async closeTrace(traceUUID: string) {
+    async closeTrace(traceUUID: string): Promise<void> {
         const traceToClose = this.fOpenTraces.get(traceUUID);
         if (traceToClose) {
             await this.tspClient.deleteTrace(traceUUID);

diff --git a/viewer-prototype/src/common/utils/time-range.ts b/viewer-prototype/src/common/utils/time-range.ts
@@ -19,7 +19,7 @@ export class TimeRange {
      * Get the range start time.
      * If an offset is present the return value is start + offset.
      */
-    public getstart() {
+    public getstart(): number {
         if (this.offset !== undefined) {
             return this.start + this.offset;
         }
@@ -30,7 +30,7 @@ export class TimeRange {
      * Get the range end time.
      * If an offset is present the return value is end + offset.
      */
-    public getEnd() {
+    public getEnd(): number {
         if (this.offset !== undefined) {
             return this.end + this.offset;
         }
@@ -40,14 +40,14 @@ export class TimeRange {
     /**
      * Get range duration
      */
-    public getDuration() {
+    public getDuration(): number {
         return this.end - this.start;
     }
 
     /**
      * Return the time offset
      */
-    public getOffset() {
+    public getOffset(): number | undefined {
         return this.offset;
     }
 }