oci/namespace: remove unnecessary variable idx

Signed-off-by: Ma Shimiao <[email protected]>
marcoslhc · Dec 22, 2016 · 730e099 · 730e099
1 parent 98fef1c
commit 730e099
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/oci/namespaces.go b/oci/namespaces.go
@@ -4,13 +4,10 @@ import specs "github.com/opencontainers/runtime-spec/specs-go"
 
 // RemoveNamespace removes the `nsType` namespace from OCI spec `s`
 func RemoveNamespace(s *specs.Spec, nsType specs.NamespaceType) {
-	idx := -1
 	for i, n := range s.Linux.Namespaces {
 		if n.Type == nsType {
-			idx = i
+			s.Linux.Namespaces = append(s.Linux.Namespaces[:i], s.Linux.Namespaces[i+1:]...)
+			return
 		}
 	}
-	if idx >= 0 {
-		s.Linux.Namespaces = append(s.Linux.Namespaces[:idx], s.Linux.Namespaces[idx+1:]...)
-	}
 }