Fix bug #15 to avoid fail when repo exists #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Let A = repo exists, B = git module forcing
* There's a case of A and not B, which should skip the task
* If the task isn't skipped,
it will try to clone the repo and failing when forcing isn't enabled
* The better approach is to skip the task when A and not B
or rather do it when not A or B
* Put another way, run the task when:
* the repo doesn't exist
* ... or ...
* the repo exists and forcing is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will try to clone the repo and failing when forcing isn't enabled
or rather do it when not A or B