eCryptfs: Fix redundant error check on ecryptfs_find_daemon_by_euid()

It is sufficient to check the return code of ecryptfs_find_daemon_by_euid(). If it returns 0, it always sets the daemon pointer to point to a valid ecryptfs_daemon. Signed-off-by: Tyler Hicks <[email protected]> Reported-by: Kees Cook <[email protected]>
marineam · Feb 27, 2013 · 1111eae · 1111eae
1 parent 1101d58
commit 1111eae
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
@@ -283,7 +283,7 @@ ecryptfs_send_message_locked(char *data, int data_len, u8 msg_type,
 	int rc;
 
 	rc = ecryptfs_find_daemon_by_euid(&daemon);
-	if (rc || !daemon) {
+	if (rc) {
 		rc = -ENOTCONN;
 		goto out;
 	}