Skip to content

Commit

Permalink
net: update consumers of MSG_MORE to recognize MSG_SENDPAGE_NOTLAST
Browse files Browse the repository at this point in the history
Commit 35f9c09 (tcp: tcp_sendpages() should call tcp_push() once)
added an internal flag MSG_SENDPAGE_NOTLAST, similar to
MSG_MORE.

algif_hash, algif_skcipher, and udp used MSG_MORE from tcp_sendpages()
and need to see the new flag as identical to MSG_MORE.

This fixes sendfile() on AF_ALG.

v3: also fix udp

Cc: Tom Herbert <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: <[email protected]> # 3.4.x + 3.2.x
Reported-and-tested-by: Shawn Landden <[email protected]>
Original-patch: Richard Weinberger <[email protected]>
Signed-off-by: Shawn Landden <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Shawn Landden authored and davem330 committed Nov 29, 2013
1 parent 85493e6 commit d3f7d56
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions crypto/algif_hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ static ssize_t hash_sendpage(struct socket *sock, struct page *page,
struct hash_ctx *ctx = ask->private;
int err;

if (flags & MSG_SENDPAGE_NOTLAST)
flags |= MSG_MORE;

lock_sock(sk);
sg_init_table(ctx->sgl.sg, 1);
sg_set_page(ctx->sgl.sg, page, size, offset);
Expand Down
3 changes: 3 additions & 0 deletions crypto/algif_skcipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,9 @@ static ssize_t skcipher_sendpage(struct socket *sock, struct page *page,
struct skcipher_sg_list *sgl;
int err = -EINVAL;

if (flags & MSG_SENDPAGE_NOTLAST)
flags |= MSG_MORE;

lock_sock(sk);
if (!ctx->more && ctx->used)
goto unlock;
Expand Down
3 changes: 3 additions & 0 deletions net/ipv4/udp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,9 @@ int udp_sendpage(struct sock *sk, struct page *page, int offset,
struct udp_sock *up = udp_sk(sk);
int ret;

if (flags & MSG_SENDPAGE_NOTLAST)
flags |= MSG_MORE;

if (!up->pending) {
struct msghdr msg = { .msg_flags = flags|MSG_MORE };

Expand Down

0 comments on commit d3f7d56

Please sign in to comment.