Skip to content

Commit

Permalink
drm/i915: fix panel unlock register mask
Browse files Browse the repository at this point in the history
Use the correct mask for the unlock bits. In theory this could have lead
to incorrect asserts but this is unlikely in practise.

Signed-off-by: Jani Nikula <[email protected]>
Reviewed-by: Paulo Zanoni <[email protected]>
Reviewed-by: Ville Syrjälä <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>
  • Loading branch information
jnikula authored and danvet committed Sep 3, 2014
1 parent ecdb5fd commit ec49ba2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ static void assert_panel_unlocked(struct drm_i915_private *dev_priv,

val = I915_READ(pp_reg);
if (!(val & PANEL_POWER_ON) ||
((val & PANEL_UNLOCK_REGS) == PANEL_UNLOCK_REGS))
((val & PANEL_UNLOCK_MASK) == PANEL_UNLOCK_REGS))
locked = false;

if (I915_READ(lvds_reg) & LVDS_PIPEB_SELECT)
Expand Down

0 comments on commit ec49ba2

Please sign in to comment.