[IMP] sale_commission: Backport improvements from 12.0

* Add description to all models
* Adapt commission amount computation courtesy of Simone Rubi
* Adapt views
* Fixed dependencies in constraint

sale_commission_formula/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     'name': 'Sale Commission Formula',
-    'version': '11.0.1.1.0',
+    'version': '11.0.1.2.0',
     'category': 'Sale',
     'license': 'AGPL-3',
     'summary': 'Sale commissions computed by formulas',

sale_commission_formula/models/__init__.py

@@ -1,5 +1,4 @@
 # License AGPL-3 - See https://www.gnu.org/licenses/agpl-3.0.html
 
-from . import account_invoice
 from . import sale_commission
 from . import sale_commission_mixin

sale_commission_formula/models/sale_commission_mixin.py

@@ -17,15 +17,17 @@ def _get_formula_input_dict(self):
             'self': self,
         }
 
-    def _compute_amount(self):
-        applicable_lines = self.filtered(lambda x: (
-            not x.source_product_id.commission_free and x.commission
-            and x.commission.commission_type == 'formula'
-        ))
-        for line in applicable_lines:
-            formula = line.commission.formula
-            results = line._get_formula_input_dict()
+    def _get_commission_amount(self, commission, subtotal, product, quantity):
+        """Get the commission amount for the data given. To be called by
+        compute methods of children models.
+        """
+        self.ensure_one()
+        if (not product.commission_free and commission and
+                commission.commission_type == 'formula'):
+            formula = commission.formula
+            results = self._get_formula_input_dict()
             safe_eval(formula, results, mode="exec", nocopy=True)
-            line.amount = float(results['result'])
-        rest = self - applicable_lines
-        super(SaleCommissionLineMixin, rest)._compute_amount()
+            return float(results['result'])
+        return super()._get_commission_amount(
+            commission, subtotal, product, quantity,
+        )