[BitCode] Make sure atomicrmw's argument is an actual PointerType

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@271851 91177308-0d34-0410-b5e6-96231b3b80d8
marler8997 · Jun 5, 2016 · 98090ec · 98090ec
1 parent afe713a
commit 98090ec
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp
@@ -5340,6 +5340,7 @@ std::error_code BitcodeReader::parseFunctionBody(Function *F) {
       unsigned OpNum = 0;
       Value *Ptr, *Val;
       if (getValueTypePair(Record, OpNum, NextValueNo, Ptr) ||
+          !isa<PointerType>(Ptr->getType()) ||
           popValue(Record, OpNum, NextValueNo,
                     cast<PointerType>(Ptr->getType())->getElementType(), Val) ||
           OpNum+4 != Record.size())

diff --git a/test/Bitcode/Inputs/invalid-nonpointer-atomicrmw.bc b/test/Bitcode/Inputs/invalid-nonpointer-atomicrmw.bc
diff --git a/test/Bitcode/invalid.test b/test/Bitcode/invalid.test
@@ -227,3 +227,8 @@ RUN: not llvm-dis -disable-output %p/Inputs/invalid-nonpointer-storeatomic.bc 2>
 RUN:   FileCheck --check-prefix=NONPOINTER-STOREATOMIC %s
 
 NONPOINTER-STOREATOMIC: Invalid record
+
+RUN: not llvm-dis -disable-output %p/Inputs/invalid-nonpointer-atomicrmw.bc 2>&1 | \
+RUN:   FileCheck --check-prefix=NONPOINTER-ATOMICRMW %s
+
+NONPOINTER-ATOMICRMW: Invalid record