Remove defaultauthdb portion of mongo connection string (metabase#41553)

marregui · Apr 19, 2024 · 271bbdf · 271bbdf
1 parent c6b7bda
commit 271bbdf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/modules/drivers/mongo/src/metabase/driver/mongo/connection.clj b/modules/drivers/mongo/src/metabase/driver/mongo/connection.clj
@@ -21,7 +21,7 @@
 
 (defn db-details->connection-string
   "Generate connection string from database details."
-  [{:keys [use-conn-uri conn-uri host port dbname additional-options use-srv ssl] :as _db-details}]
+  [{:keys [use-conn-uri conn-uri host port additional-options use-srv ssl] :as _db-details}]
   ;; Connection string docs:
   ;; http://mongodb.github.io/mongo-java-driver/4.11/apidocs/mongodb-driver-core/com/mongodb/ConnectionString.html
   (if use-conn-uri
@@ -33,7 +33,6 @@
      host
      (when (and (not use-srv) (some? port)) (str ":" port))
      "/"
-     dbname
      "?connectTimeoutMS=" (driver.u/db-connection-timeout-ms)
      "&serverSelectionTimeoutMS=" (driver.u/db-connection-timeout-ms)
      (when ssl "&ssl=true")

diff --git a/modules/drivers/mongo/test/metabase/driver/mongo/connection_test.clj b/modules/drivers/mongo/test/metabase/driver/mongo/connection_test.clj
@@ -38,7 +38,7 @@
                     :use-srv true}]
     (testing "mongo+srv connection string used when :use-srv is thruthy"
       (is (str/includes? (mongo.connection/db-details->connection-string db-details)
-                         "mongodb+srv://test-host.place.com/datadb"))
+                         "mongodb+srv://test-host.place.com/"))
       (let [settings (mongo.connection/db-details->mongo-client-settings db-details)
             ^MongoCredential credential (.getCredential settings)]
         (is (= "test-user" (.getUserName credential)))