Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SendGrid transport and support API keys #62

Merged
merged 1 commit into from
May 6, 2016
Merged

Document SendGrid transport and support API keys #62

merged 1 commit into from
May 6, 2016

Conversation

vitorio
Copy link
Contributor

@vitorio vitorio commented Apr 10, 2016

The SendGrid transport works, but doesn't support API keys. This adds the transport to the README, and adds transparent support for API keys. Supply a username and password as user and key, or just an API key as key.

@codecov-io
Copy link

Current coverage is 85.28%

Merging #62 into develop will not affect coverage as of af76b40

@@            develop     #62   diff @@
=======================================
  Files            10      10       
  Stmts           768     768       
  Branches          0       0       
  Methods           0       0       
=======================================
  Hit             655     655       
  Partial           0       0       
  Missed          113     113       

Review entire Coverage Diff as of af76b40

Powered by Codecov. Updated on successful CI builds.

@amcgregor amcgregor merged commit e4c91f7 into marrow:develop May 6, 2016
@amcgregor
Copy link
Member

Minor note, the final released version will use simpler configuration keys "user" and "key", instead of the current underscore-delimited ones.

@vitorio
Copy link
Contributor Author

vitorio commented May 6, 2016

Thank you!

@amcgregor
Copy link
Member

Yeah, apologies for not paying attention to this earlier. Notifications were disabled for me on this project for some reason, which I have now fixed.

@vitorio vitorio deleted the sgbearer2 branch May 6, 2016 22:45
@amcgregor amcgregor added 2.enhancement A request for a new feature or altered behaviour. transport:sendgrid Sendgrid API transport. labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.enhancement A request for a new feature or altered behaviour. transport:sendgrid Sendgrid API transport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants