Raise error for duplicate headers in hash mode (fixes #44) #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #44 the current behaviour for hash mode has the potential leads to confusion.
This change makes Xsv raise an error when trying to enter hash mode on a sheet with duplicate non-nil header values. I left nil out of scope because it's common for Excel sheets to have empty columns for spacing or trailing on the end of the sheet.
I'm not sure if we really want this behaviour, and I'm planning on bumping the minor version to signal the potential breakage this can cause. @shkm @voxik looking forward to your comments on this one.