Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle columns without r attribute (#48) #50

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

martijn
Copy link
Owner

@martijn martijn commented Jan 13, 2023

This should fix the problem reported in #48

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #50 (65c65e8) into main (8796222) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   99.42%   99.44%   +0.01%     
==========================================
  Files          21       21              
  Lines         700      723      +23     
==========================================
+ Hits          696      719      +23     
  Misses          4        4              
Impacted Files Coverage Δ
lib/xsv/sheet_rows_handler.rb 98.36% <100.00%> (+0.17%) ⬆️
test/sheet_rows_handler_test.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martijn martijn merged commit 7f68eeb into main Feb 16, 2023
@martijn martijn deleted the fix-columns-without-r-attribute branch May 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants