Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Result block value for SevenZipReader.open & .open_file #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PikachuEXE
Copy link

They were always returning nil (from SevenZipReader#close_file)

Also changed &block + block.call to block_given? + yield

They were always returning `nil` (from SevenZipReader#close_file)

Also changed &block + block.call to block_given? + yield
@PikachuEXE PikachuEXE force-pushed the feature/return-block-value branch from 7532c11 to ffc6edc Compare March 10, 2017 09:42
@PikachuEXE
Copy link
Author

This solves #24

@PikachuEXE
Copy link
Author

@masamitsu-murase
I guess this one takes less time to process (the build is green already

@PikachuEXE
Copy link
Author

Hi
Any thought on this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant