Skip to content

Commit

Permalink
tap-v1 nsh: Disable ARCH_IRQPRIO & ARCH_HIPRI_INTERRUP
Browse files Browse the repository at this point in the history
   This insures the common exception handler will not be
   re-entered. The handler does not support nested interrupts
   and the interrupt stack pointer and context will be overwritten
   resulting in hard to debug hardfaults.

   If all the priorities are equal the NVIC prevents the
   preemption. The startup code defaults all the priorities
   to the same value 128.

   This change safeguards in 2 ways 1) By disabling
   CONFIG_ ARCH_IRQPRIO: up_prioritize_irq cannot be called.
   This will insure that all HW interrupts are at the same
   priority.

   2) By disabling CONFIG_ARCH_HIPRI_INTERRUP, the common
   exception will disable any interrupts during interrupt
   processing.
  • Loading branch information
David Sidrane authored and dagar committed Sep 25, 2018
1 parent 3f1a155 commit 6ec693b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions platforms/nuttx/nuttx-configs/tap-v1/nsh/defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ CONFIG_ARCH_HAVE_MPU=y
CONFIG_ARCH_HAVE_RESET=y
# CONFIG_ARCH_HAVE_RTC_SUBSECONDS is not set
# CONFIG_ARCH_USE_MPU is not set
CONFIG_ARCH_IRQPRIO=y
# CONFIG_ARCH_IRQPRIO is not set
CONFIG_ARCH_STACKDUMP=y
# CONFIG_ENDIAN_BIG is not set
# CONFIG_ARCH_IDLE_CUSTOM is not set
Expand All @@ -643,7 +643,7 @@ CONFIG_BOARD_LOOPSPERMSEC=16717
CONFIG_ARCH_HAVE_INTERRUPTSTACK=y
CONFIG_ARCH_INTERRUPTSTACK=750
CONFIG_ARCH_HAVE_HIPRI_INTERRUPT=y
CONFIG_ARCH_HIPRI_INTERRUPT=y
# CONFIG_ARCH_HIPRI_INTERRUPT is not set

#
# Boot options
Expand Down

0 comments on commit 6ec693b

Please sign in to comment.