Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactDOM/Server #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ReactDOM/Server #24

wants to merge 3 commits into from

Conversation

drolsen
Copy link

@drolsen drolsen commented Aug 2, 2019 •
edited
Loading

#23

  • Updates react versions from 16.6.2 to 16.8.0 with 16.9.0 now into beta.
  • Adds missing ReactDOM/Server which is both available and reduced 19kb from my bundle!

Tested on node 10.15.1 both yarn and npm

image

@drolsen
Copy link
Author

drolsen commented Aug 2, 2019 •
edited
Loading

Why would angular and propTypes being failing to build?
https://travis-ci.org/mastilver/module-to-cdn/jobs/567163784

Locally all tests pass, but looks like timeouts on three libs according to the travis job.
Unsure how to resolve timeouts on libs unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drolsen