Implementation #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
я був дуже близько ) |
vpolets
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
погано що в тебе поразка коли робиш спробу походити кудись, коли вже ясно що ти програв і видно що ходів немає
Що до спрощення, гру можна було написати на класах і не писати для кожного ходу свою функцію, а розвертати матрицю в правильноу напрямку, збирати до купи - і тоді розвертати як було до того
Comment on lines
+216
to
+360
| matrixModel[row - 1][column] = 0; | ||
| isMoved = true; | ||
| } | ||
| } | ||
|
|
||
| if (isMoved) { | ||
| return moveDown(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // combine cells if they are equal and then call move function | ||
| function combineDown() { | ||
| for (let column = 0; column < size; column++) { | ||
| for (let row = size - 1; row >= 1; row--) { | ||
| if (matrixModel[row - 1][column] === matrixModel[row][column] | ||
| && matrixModel[row][column] > 0) { | ||
| matrixModel[row - 1][column] *= 2; | ||
| matrixModel[row][column] = 0; | ||
| currentScore += matrixModel[row - 1][column]; | ||
| scoreContainer.textContent = currentScore; | ||
| moveDown(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // cells of each row move left untill | ||
| // all existed moves in current row be done | ||
| function moveLeft() { | ||
| for (let row = 0; row < size; row++) { | ||
| let isMoved = false; | ||
|
|
||
| for (let column = 1; column < size; column++) { | ||
| if (matrixModel[row][column - 1] === 0 | ||
| && matrixModel[row][column] > 0) { | ||
| matrixModel[row][column - 1] = matrixModel[row][column]; | ||
| matrixModel[row][column] = 0; | ||
| isMoved = true; | ||
| } | ||
| } | ||
|
|
||
| if (isMoved) { | ||
| return moveLeft(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // combine cells if they are equal and then call move function | ||
| function combineLeft() { | ||
| for (let row = 0; row < size; row++) { | ||
| for (let column = 1; column < size; column++) { | ||
| if (matrixModel[row][column - 1] === matrixModel[row][column] | ||
| && matrixModel[row][column] > 0) { | ||
| matrixModel[row][column - 1] *= 2; | ||
| matrixModel[row][column] = 0; | ||
| currentScore += matrixModel[row][column - 1]; | ||
| scoreContainer.textContent = currentScore; | ||
| moveLeft(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // cells of each row move right untill | ||
| // all existed moves in current row be done | ||
| function moveRight() { | ||
| for (let row = 0; row < size; row++) { | ||
| let isMoved = false; | ||
|
|
||
| for (let column = size - 1; column >= 1; column--) { | ||
| if (matrixModel[row][column] === 0 | ||
| && matrixModel[row][column - 1] > 0) { | ||
| matrixModel[row][column] = matrixModel[row][column - 1]; | ||
| matrixModel[row][column - 1] = 0; | ||
| isMoved = true; | ||
| } | ||
| } | ||
|
|
||
| if (isMoved) { | ||
| return moveRight(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // combine cells if they are equal and then call move functiongi | ||
| function combineRight() { | ||
| for (let row = 0; row < size; row++) { | ||
| for (let column = size - 1; column >= 1; column--) { | ||
| if (matrixModel[row][column - 1] === matrixModel[row][column] | ||
| && matrixModel[row][column] > 0) { | ||
| matrixModel[row][column - 1] *= 2; | ||
| matrixModel[row][column] = 0; | ||
| currentScore += matrixModel[row][column - 1]; | ||
| scoreContainer.textContent = currentScore; | ||
| moveRight(row, column); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
я певен це все можна дуже спростити, але реалізація непогана, код достатньо чистий, мені подобається
Comment on lines
+183
to
+212
| if (event.keyCode === 38) { | ||
| if (canMoveU()) { | ||
| moveUp(); | ||
| combineUp(); | ||
| generate(); | ||
| render(); | ||
| } | ||
| } else if (event.keyCode === 40) { | ||
| if (canMoveD()) { | ||
| moveDown(); | ||
| combineDown(); | ||
| generate(); | ||
| render(); | ||
| } | ||
| } else if (event.keyCode === 37) { | ||
| if (canMoveL()) { | ||
| moveLeft(); | ||
| combineLeft(); | ||
| generate(); | ||
| render(); | ||
| } | ||
| } else if (event.keyCode === 39) { | ||
| if (canMoveR()) { | ||
| moveRight(); | ||
| combineRight(); | ||
| generate(); | ||
| render(); | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK - https://DmytroArkhypenko.github.io/js_2048_game/