Added content #667
Open
Added content #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinnieJ-2k20
suggested changes
Mar 23, 2021
src/index.html
Outdated
Comment on lines
12
to
28
| <div id="qa-block" class="block"> | ||
| <div class="red-border"> | ||
| <div class="blue-border"> | ||
| <div class="red-border"> | ||
| <div class="yellow-border"> | ||
| <div class="red-border"> | ||
| <div class="text"> | ||
| In programming languages, a closure is a technique for implementing lexically | ||
| scoped name binding in a language with first-class functions. Operationally, a | ||
| closure is a record storing a function together with an environment. | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
You are creating too many unnecessary elements.
If necessary, you can assign multiple classes to one HTML element:
class="block blue-border"
Also, you can add red border as border to element and blue or yellow colof as background.
Try completing this task with no more than three divs layers.
|
Last commit wrong text. 'blue' must be 'block'. Should I make a new commit? |
VinnieJ-2k20
suggested changes
Mar 23, 2021
src/style.css
Outdated
Comment on lines
11
to
28
| .blue { | ||
| background-color: #308dc0; | ||
| border: 1px solid #e95d49; | ||
| padding: 10px; | ||
| } | ||
|
|
||
| .yellow { | ||
| background-color: #ffa500; | ||
| border: 1px solid #e95d49; | ||
| padding: 10px; | ||
| } | ||
|
|
||
| .text { | ||
| border: 1px solid #e95d49; | ||
| margin: 0; | ||
| padding: 10px; | ||
| background-color: #ddd; | ||
| } |
There was a problem hiding this comment.
You have same styles for border and padding in three selectors.
Remember, don't repeat yourself.
Create one more common class for these styles.
Also, you can safely combine .blue and .block into one class. They have no overlapping styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK