ready task #5274
ready task #5274
Conversation
maksbtw
commented
Jan 16, 2025
maksbtw
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your implementation is mostly on point, there are a few critical issues that need to be addressed before we can approve the pull request:
-
BEM Methodology: The task requires that each BEM block has its own separate file. Currently, all styles are in a single
style.cssfile. Please separate the styles into individual files for each BEM block. -
Image Files: Ensure that the
images/star-active.svgandimages/star.svgfiles exist in the specified paths. These images are crucial for the visual representation of the star rating system.
Once these issues are resolved, your code will be ready for approval. Keep up the great work, and don't hesitate to reach out if you need any assistance! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/style.css
Outdated
| .stars__star { | ||
| width: 16px; | ||
| height: 16px; | ||
| background-image: url(images/star.svg); |
There was a problem hiding this comment.
Ensure that the 'images/star.svg' file exists in the specified path. If the image is missing, the stars will not display correctly.
src/style.css
Outdated
| } | ||
|
|
||
| .stars--1 > :nth-child(-n + 1) { | ||
| background-image: url(images/star-active.svg); |
There was a problem hiding this comment.
Ensure that the 'images/star-active.svg' file exists in the specified path. This image is used for active stars and is crucial for the visual representation of the rating.
There was a problem hiding this comment.
Great job on addressing the previous review comments and organizing your code using the BEM methodology! 🎉 Your implementation now meets the task requirements, with styles separated into individual files for each BEM block. However, remember to ensure that each BEM block has its own CSS file and consider whether style.css is necessary or if individual imports in the HTML file would be more appropriate. Also, double-check that the image files star.svg and star-active.svg are in the correct paths for the star rating system to function properly. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -9,10 +9,53 @@ | |||
| <title>Stars</title> | |||
| <link | |||
| rel="stylesheet" | |||
| href="./style.css" | |||
| href="./styles/style.css" | |||
There was a problem hiding this comment.
The link to the stylesheet is pointing to a single style.css file. According to the task requirements, each BEM block should have its own separate CSS file. Please separate the styles into individual files for each BEM block and update the links accordingly.
| @@ -0,0 +1,9 @@ | |||
| @import './stars.css'; | |||
There was a problem hiding this comment.
While importing stars.css is a good practice, ensure that each BEM block has its own separate CSS file as per the task requirements. Consider whether style.css is necessary or if it should be replaced by individual imports in the HTML file.
