solution #1192
Open
solution #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moroz-Dmytro
suggested changes
Dec 4, 2024
src/App.jsx
Outdated
| </ul> | ||
| </div> | ||
| export const App = () => { | ||
| const [activeTabId, setActiveTabId] = useState('tab-1'); |
There was a problem hiding this comment.
Suggested change
| const [activeTabId, setActiveTabId] = useState('tab-1'); | |
| const [activeTabId, setActiveTabId] = useState(tabs[0].id); |
src/App.jsx
Outdated
Comment on lines
22
to
26
| let selectedTitle = 'Selected tab is '; | ||
|
|
||
| if (activeTab) { | ||
| selectedTitle += activeTab.title; | ||
| } |
src/components/Tabs/Tabs.jsx
Outdated
| <div className="tabs is-boxed"> | ||
| <ul> | ||
| {tabs.map(tab => { | ||
| const className = tab.id === validTabId ? 'is-active' : ''; |
There was a problem hiding this comment.
src/components/Tabs/Tabs.jsx
Outdated
Comment on lines
4
to
6
| const validTabId = tabs.some(tab => tab.id === activeTabId) | ||
| ? activeTabId | ||
| : tabs[0].id; |
There was a problem hiding this comment.
It is not really needed
Suggested change
| const validTabId = tabs.some(tab => tab.id === activeTabId) | |
| ? activeTabId | |
| : tabs[0].id; |
src/components/Tabs/Tabs.jsx
Outdated
| })} | ||
| </ul> | ||
| <div className="block" data-cy="TabContent"> | ||
| {tabs.find(tab => tab.id === validTabId)?.content} |
There was a problem hiding this comment.
Create variable for {tabs.find(tab => tab.id === validTabId)
StasSokolov1
approved these changes
Dec 23, 2024
| {tabs.map(tab => ( | ||
| <li | ||
| key={tab.id} | ||
| className={classNames({ 'is-active': tab.id === activeTabId })} |
There was a problem hiding this comment.
let's move into const and reuse tab.id === activeTabId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK