Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1207

wants to merge 1 commit into from

Conversation

AndreaTkachuk
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the Tabs component and integrating it with App.jsx! 🎉 Your code meets the task requirements and constraints effectively. The only minor suggestion is to initialize activeTabId with a valid tab ID to ensure the first tab is active by default. This will prevent any unexpected behavior. Keep up the excellent work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<div className="section">
<h1 className="title">Selected tab is Tab 1</h1>
export const App = () => {
const [activeTabId, setActiveTabId] = useState('');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial state of activeTabId is set to an empty string. According to the task description, if activeTabId does not match any object in the tabs array, the first one should be active. Consider initializing activeTabId with the ID of the first tab, e.g., useState('tab-1'), to ensure the first tab is active by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants