Skip to content

Commit

Permalink
Configure: disabled gcc atomics with Sun C (ticket #1261).
Browse files Browse the repository at this point in the history
Oracle Developer Studio 12.5 introduced GCC-compatible __sync builtins.
Unfortunately, these builtins are neither GCC-compatible (they generate
warnings when used with volatile), nor working (unexpectedly fail on
unpredictable combinations of code layout and compiler flags).  As such,
the gcc builtin atomic operations configure test explicitly disabled when
compiling with Sun C.
  • Loading branch information
mdounin committed May 15, 2017
1 parent e172576 commit 38e87ea
Showing 1 changed file with 19 additions and 15 deletions.
34 changes: 19 additions & 15 deletions auto/cc/conf
Original file line number Diff line number Diff line change
Expand Up @@ -178,21 +178,25 @@ if [ "$NGX_PLATFORM" != win32 ]; then
fi


ngx_feature="gcc builtin atomic operations"
ngx_feature_name=NGX_HAVE_GCC_ATOMIC
ngx_feature_run=yes
ngx_feature_incs=
ngx_feature_path=
ngx_feature_libs=
ngx_feature_test="long n = 0;
if (!__sync_bool_compare_and_swap(&n, 0, 1))
return 1;
if (__sync_fetch_and_add(&n, 1) != 1)
return 1;
if (n != 2)
return 1;
__sync_synchronize();"
. auto/feature
if [ "$NGX_CC_NAME" = "sunc" ]; then
echo "checking for gcc builtin atomic operations ... disabled"
else
ngx_feature="gcc builtin atomic operations"
ngx_feature_name=NGX_HAVE_GCC_ATOMIC
ngx_feature_run=yes
ngx_feature_incs=
ngx_feature_path=
ngx_feature_libs=
ngx_feature_test="long n = 0;
if (!__sync_bool_compare_and_swap(&n, 0, 1))
return 1;
if (__sync_fetch_and_add(&n, 1) != 1)
return 1;
if (n != 2)
return 1;
__sync_synchronize();"
. auto/feature
fi


if [ "$NGX_CC_NAME" = "ccc" ]; then
Expand Down

0 comments on commit 38e87ea

Please sign in to comment.