Merge pull request iterative#1949 from Suor/tests-extra-processes

test: never run updater nor analytics in tests
mathemaphysics · May 1, 2019 · 755a8ba · 755a8ba
2 parents 40ace17 + 6e0e5b4
commit 755a8ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/tests/__main__.py b/tests/__main__.py
@@ -10,12 +10,8 @@
     "PATH", "{}:{}".format(os.path.join(REPO_ROOT, "bin"), os.getenv("PATH"))
 )
 os.putenv("DVC_HOME", REPO_ROOT)
-os.putenv("DVC_TEST", "true")
 
-if len(sys.argv) == 1:
-    params = ""
-else:
-    params = " ".join(sys.argv[1:])
+params = " ".join(sys.argv[1:])
 
 cmd = (
     "py.test -v -n=4 --timeout=600 --timeout_method=thread --log-level=debug"

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -5,11 +5,16 @@
 from git import Repo
 from git.exc import GitCommandNotFound
 
+from dvc.utils.compat import cast_bytes_py2
 from dvc.remote.ssh.connection import SSHConnection
 from dvc.repo import Repo as DvcRepo
 from .basic_env import TestDirFixture
 
 
+# Prevent updater and analytics from running their processes
+os.environ[cast_bytes_py2("DVC_TEST")] = cast_bytes_py2("true")
+
+
 @pytest.fixture(autouse=True)
 def reset_loglevel(request, caplog):
     """