Settings to control disabled features

mathieudutour · Apr 5, 2018 · 7049116 · 7049116
1 parent 6602691
commit 7049116
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/src/Settings.plist b/src/Settings.plist
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<array>
+	<dict>
+		<key>DefaultValue</key>
+		<string>show-recently-pushed-branches</string>
+		<key>Key</key>
+		<string>disabledFeatures</string>
+		<key>Title</key>
+		<string>Disabled features</string>
+		<key>Titles</key>
+		<array>
+			<string></string>
+		</array>
+		<key>Type</key>
+		<string>TextField</string>
+	</dict>
+</array>
+</plist>
diff --git a/src/global.html b/src/global.html
@@ -32,20 +32,35 @@
       }
     };
 
+    const injectSettings = (namespace, data) => {
+      if (namespace === "sync") {
+        return {
+          ...data,
+          options: {
+            ...(data.options || {}),
+            disabledFeatures: safari.extension.settings.disabledFeatures
+          }
+        };
+      } else {
+        return data;
+      }
+    };
+
     const safeParse = data => {
       try {
-        const parsed = JSON.parse(data) || {};
-        parsed.options = parsed.options || {};
-        parsed.options.disabledFeatures = parsed.options.disabledFeatures || "show-recently-pushed-branches";
-        return parsed;
+        return JSON.parse(data) || {};
       } catch {
         return {};
       }
     };
 
     const localStorageKey = namespace => `refined-github:${namespace}`;
     const readLocalStorage = namespace =>
-      safeParse(localStorage.getItem(localStorageKey(namespace)));
+      injectSettings(
+        namespace,
+        safeParse(localStorage.getItem(localStorageKey(namespace)))
+      );
+
     const writeLocalStorage = (namespace, data) =>
       localStorage.setItem(localStorageKey(namespace), JSON.stringify(data));