[Tools/statuspage.1m.rb] Fix screenshot, use proper fetching #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed thes screenshot here (and in several other places) is broken because of imgur's http -> https redirect breaking whatever process is loading them in. Instead, this moves it within the repository and uses it from there. Also avoids using the `open(url)` pattern because it tries to run it at the Ruby kernel level rather than in a safer spot. [ref](https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/Open)
sprak3000
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed thes screenshot here (and in several other places) is broken because of imgur's http -> https redirect breaking whatever process is loading them in for the documentation. Instead, this moves it within the repository and uses it from there.
Also avoids using the
open(url)pattern because it tries to run it at the Ruby kernel level rather than in a safer spot. 1Footnotes
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Security/Open ↩