Skip to content

Commit

Permalink
auth settings: Put Apple "Team ID" before the things it namespaces.
Browse files Browse the repository at this point in the history
I believe the Bundle ID (aka App ID) and Services ID have meaning only
relative to a specific Team ID.  In particular, in some places in the
developer.apple.com UI, they're displayed in a fully-qualified form
like "ABCDE12345.com.example.app", where "com.example.app" is the
App ID or Services ID and ABCDE12345 is the Team ID.
  • Loading branch information
gnprice committed Jun 24, 2020
1 parent 9b620df commit 0021dfe
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions docs/production/authentication-methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,11 @@ domain for your server).
```
1. Configure the "Apple authentication" section of
`/etc/zulip/settings.py`. Use the "Services ID" as
`/etc/zulip/settings.py`. Use the "Team ID" as
`SOCIAL_AUTH_APPLE_TEAM`, "Services ID" as
`SOCIAL_AUTH_APPLE_SERVICES_ID`, "Bundle ID" as
`SOCIAL_AUTH_APPLE_BUNDLE_ID`, "Key ID" as `SOCIAL_AUTH_APPLE_KEY`
and "Team ID" as `SOCIAL_AUTH_APPLE_TEAM` in `settings.py` file.
`SOCIAL_AUTH_APPLE_BUNDLE_ID`, and "Key ID" as
`SOCIAL_AUTH_APPLE_KEY`.
1. In the Apple developer site, configure the domains your Zulip
server uses when sending outgoing email notifications. (This is
Expand Down
2 changes: 1 addition & 1 deletion zproject/prod_settings_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,9 @@
#
# https://zulip.readthedocs.io/en/latest/production/authentication-methods.html#sign-in-with-apple
#
#SOCIAL_AUTH_APPLE_TEAM = "<your Team ID>"
#SOCIAL_AUTH_APPLE_SERVICES_ID = "<your Services ID>"
#SOCIAL_AUTH_APPLE_BUNDLE_ID = "<your Bundle ID>"
#SOCIAL_AUTH_APPLE_TEAM = "<your Team ID>"
#SOCIAL_AUTH_APPLE_KEY = "<your Key ID>"

########
Expand Down

0 comments on commit 0021dfe

Please sign in to comment.