Skip to content

Commit

Permalink
integrations: Rename social media logos to bypass Adblock Plus.
Browse files Browse the repository at this point in the history
Adblock Plus's "Block social media icons tracking" setting blocked
integration logos for social media platforms from loading, so the logos
are renamed to bypass this.

Fixes zulip#11590.
  • Loading branch information
synicalsyntax authored and rishig committed Feb 23, 2019
1 parent d6483a9 commit 33bd523
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions zerver/lib/integrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,8 @@ def __init__(self, name: str, *args: Any, **kwargs: Any) -> None:
legacy=True
),
'twitter': Integration('twitter', 'twitter', ['customer-support', 'marketing'],
# _ needed to get around adblock plus
logo='static/images/integrations/logos/twitte_r.svg',
doc='zerver/integrations/twitter.md'),
} # type: Dict[str, Integration]

Expand All @@ -476,12 +478,16 @@ def __init__(self, name: str, *args: Any, **kwargs: Any) -> None:
logo_alt='Dark Sky logo'),
HubotIntegration('google-hangouts', ['communication'], display_name='Google Hangouts',
logo_alt='Google Hangouts logo'),
HubotIntegration('instagram', ['misc'], display_name='Instagram'),
HubotIntegration('instagram', ['misc'], display_name='Instagram',
# _ needed to get around adblock plus
logo='static/images/integrations/logos/instagra_m.svg'),
HubotIntegration('mailchimp', ['communication', 'marketing'],
display_name='MailChimp'),
HubotIntegration('google-translate', ['misc'],
display_name="Google Translate", logo_alt='Google Translate logo'),
HubotIntegration('youtube', ['misc'], display_name='YouTube'),
HubotIntegration('youtube', ['misc'], display_name='YouTube',
# _ needed to get around adblock plus
logo='static/images/integrations/logos/youtub_e.svg'),
] # type: List[HubotIntegration]

for hubot_integration in HUBOT_INTEGRATIONS:
Expand Down

0 comments on commit 33bd523

Please sign in to comment.