js: Add "use strict" directive to CommonJS files.

ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <[email protected]>
matt- · Aug 1, 2020 · 6ec808b · 6ec808b
1 parent 39c3a02
commit 6ec808b
Show file tree

Hide file tree

Showing 370 changed files with 746 additions and 2 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -7,7 +7,7 @@
     "parser": "babel-eslint",
     "parserOptions": {
         "warnOnUnsupportedTypeScriptVersion": false,
-        "sourceType": "module"
+        "sourceType": "unambiguous"
     },
     "plugins": ["eslint-plugin-empty-returns"],
     "rules": {
@@ -29,6 +29,7 @@
                 "newlines-between": "always"
             }
         ],
+        "import/unambiguous": "error",
         "new-cap": [
             "error",
             {
@@ -88,7 +89,7 @@
         ],
         "radix": "error",
         "spaced-comment": "off",
-        "strict": "off",
+        "strict": "error",
         "valid-typeof": ["error", {"requireStringLiterals": true}],
         "yoda": "error"
     },
@@ -331,6 +332,12 @@
                 "@typescript-eslint/unified-signatures": "error"
             }
         },
+        {
+            "files": ["**/*.d.ts"],
+            "rules": {
+                "import/unambiguous": "off"
+            }
+        },
         {
             "files": ["frontend_tests/**"],
             "globals": {

diff --git a/babel.config.js b/babel.config.js
@@ -1,3 +1,5 @@
+"use strict";
+
 module.exports = {
     presets: [
         [

diff --git a/frontend_tests/casper_lib/common.js b/frontend_tests/casper_lib/common.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var util = require("util");
 
 var test_credentials = require("../../var/casper/test_credentials.js").test_credentials;

diff --git a/frontend_tests/casper_lib/polyfill.js b/frontend_tests/casper_lib/polyfill.js
@@ -1,3 +1,5 @@
+"use strict";
+
 /* eslint-env browser */
 
 // PhantomJS doesn’t support new DOMParser().parseFromString(…, "text/html").

diff --git a/frontend_tests/casper_tests/00-realm-creation.js b/frontend_tests/casper_tests/00-realm-creation.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 var email = "[email protected]";

diff --git a/frontend_tests/casper_tests/01-login.js b/frontend_tests/casper_tests/01-login.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 var realm_url = "http://zulip.zulipdev.com:9981/";

diff --git a/frontend_tests/casper_tests/02-site.js b/frontend_tests/casper_tests/02-site.js
@@ -1,3 +1,5 @@
+"use strict";
+
 /* Script for testing the web client.
 
    This runs under CasperJS.  It's an end-to-end black-box sort of test.  It

diff --git a/frontend_tests/casper_tests/03-narrow.js b/frontend_tests/casper_tests/03-narrow.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/04-compose.js b/frontend_tests/casper_tests/04-compose.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/05-subscriptions.js b/frontend_tests/casper_tests/05-subscriptions.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function stream_checkbox(stream_name) {

diff --git a/frontend_tests/casper_tests/06-settings.js b/frontend_tests/casper_tests/06-settings.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var test_credentials = require("../../var/casper/test_credentials.js").test_credentials;
 var common = require("../casper_lib/common.js");
 

diff --git a/frontend_tests/casper_tests/07-stars.js b/frontend_tests/casper_tests/07-stars.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function star_count() {

diff --git a/frontend_tests/casper_tests/08-edit.js b/frontend_tests/casper_tests/08-edit.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 casper.options.verbose = true;

diff --git a/frontend_tests/casper_tests/09-navigation.js b/frontend_tests/casper_tests/09-navigation.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 // Test basic tab navigation.

diff --git a/frontend_tests/casper_tests/10-admin.js b/frontend_tests/casper_tests/10-admin.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/11-mention.js b/frontend_tests/casper_tests/11-mention.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/12-custom-profile.js b/frontend_tests/casper_tests/12-custom-profile.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/13-user-deactivation.js b/frontend_tests/casper_tests/13-user-deactivation.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function user_row(name) {

diff --git a/frontend_tests/casper_tests/14-drafts.js b/frontend_tests/casper_tests/14-drafts.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function waitWhileDraftsVisible(then) {

diff --git a/frontend_tests/casper_tests/15-delete-message.js b/frontend_tests/casper_tests/15-delete-message.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/16-copy-and-paste.js b/frontend_tests/casper_tests/16-copy-and-paste.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/casper_tests/17-realm-linkifier.js b/frontend_tests/casper_tests/17-realm-linkifier.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

diff --git a/frontend_tests/node_tests/activity.js b/frontend_tests/node_tests/activity.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 const window_stub = $.create("window-stub");
 set_global("to_$", () => window_stub);

diff --git a/frontend_tests/node_tests/alert_words.js b/frontend_tests/node_tests/alert_words.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const params = {
     alert_words: ["alertone", "alerttwo", "alertthree", "al*rt.*s", ".+", "emoji"],
 };

diff --git a/frontend_tests/node_tests/alert_words_ui.js b/frontend_tests/node_tests/alert_words_ui.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 set_global("channel", {});

diff --git a/frontend_tests/node_tests/billing.js b/frontend_tests/node_tests/billing.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = () => {};
 const fs = require("fs");
 

diff --git a/frontend_tests/node_tests/billing_helpers.js b/frontend_tests/node_tests/billing_helpers.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const fs = require("fs");
 
 const JQuery = require("jquery");

diff --git a/frontend_tests/node_tests/blueslip_stacktrace.js b/frontend_tests/node_tests/blueslip_stacktrace.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const blueslip_stacktrace = zrequire("blueslip_stacktrace");
 
 run_test("clean_path", () => {

diff --git a/frontend_tests/node_tests/bot_data.js b/frontend_tests/node_tests/bot_data.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const _settings_bots = {
     render_bots: () => {},
 };

diff --git a/frontend_tests/node_tests/buddy_data.js b/frontend_tests/node_tests/buddy_data.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 const _page_params = {};

diff --git a/frontend_tests/node_tests/buddy_list.js b/frontend_tests/node_tests/buddy_list.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

diff --git a/frontend_tests/node_tests/channel.js b/frontend_tests/node_tests/channel.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 set_global("$", {});

diff --git a/frontend_tests/node_tests/color_data.js b/frontend_tests/node_tests/color_data.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("color_data");
 
 run_test("pick_color", () => {

diff --git a/frontend_tests/node_tests/colorspace.js b/frontend_tests/node_tests/colorspace.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("colorspace");
 
 run_test("sRGB_to_linear", () => {

diff --git a/frontend_tests/node_tests/common.js b/frontend_tests/node_tests/common.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = () => {};
 
 set_global("$", global.make_zjquery());

diff --git a/frontend_tests/node_tests/components.js b/frontend_tests/node_tests/components.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 zrequire("keydown_util");

diff --git a/frontend_tests/node_tests/compose.js b/frontend_tests/node_tests/compose.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const {JSDOM} = require("jsdom");
 const rewiremock = require("rewiremock/node");
 

diff --git a/frontend_tests/node_tests/compose_actions.js b/frontend_tests/node_tests/compose_actions.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = function () {};
 const return_false = function () {
     return false;

diff --git a/frontend_tests/node_tests/compose_fade.js b/frontend_tests/node_tests/compose_fade.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("stream_data");
 zrequire("people");
 zrequire("compose_fade");

diff --git a/frontend_tests/node_tests/compose_pm_pill.js b/frontend_tests/node_tests/compose_pm_pill.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 const _people = {

diff --git a/frontend_tests/node_tests/compose_ui.js b/frontend_tests/node_tests/compose_ui.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("compose_ui");
 zrequire("people");
 zrequire("user_status");

diff --git a/frontend_tests/node_tests/composebox_typeahead.js b/frontend_tests/node_tests/composebox_typeahead.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const emoji = zrequire("emoji", "shared/js/emoji");
 const typeahead = zrequire("typeahead", "shared/js/typeahead");
 zrequire("compose_state");

diff --git a/frontend_tests/node_tests/copy_and_paste.js b/frontend_tests/node_tests/copy_and_paste.js
@@ -1,3 +1,5 @@
+"use strict";
+
 global.stub_out_jquery();
 
 set_global("page_params", {

diff --git a/frontend_tests/node_tests/dispatch.js b/frontend_tests/node_tests/dispatch.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = function () {};
 
 const events = require("./lib/events.js");

diff --git a/frontend_tests/node_tests/dispatch_subs.js b/frontend_tests/node_tests/dispatch_subs.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const events = require("./lib/events.js");
 
 const event_fixtures = events.fixtures;

diff --git a/frontend_tests/node_tests/drafts.js b/frontend_tests/node_tests/drafts.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const XDate = require("xdate");
 
 set_global("$", global.make_zjquery());

diff --git a/frontend_tests/node_tests/dropdown_list_widget.js b/frontend_tests/node_tests/dropdown_list_widget.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("dropdown_list_widget");
 zrequire("scroll_util");
 set_global("$", global.make_zjquery());

diff --git a/frontend_tests/node_tests/echo.js b/frontend_tests/node_tests/echo.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 set_global("markdown", {});
 set_global("local_message", {

diff --git a/frontend_tests/node_tests/emoji.js b/frontend_tests/node_tests/emoji.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
 
 const events = require("./lib/events.js");

diff --git a/frontend_tests/node_tests/emoji_picker.js b/frontend_tests/node_tests/emoji_picker.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 const emoji = zrequire("emoji", "shared/js/emoji");

diff --git a/frontend_tests/node_tests/fenced_code.js b/frontend_tests/node_tests/fenced_code.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const fenced_code = zrequire("fenced_code", "shared/js/fenced_code");
 
 run_test("get_unused_fence", () => {

diff --git a/frontend_tests/node_tests/fetch_status.js b/frontend_tests/node_tests/fetch_status.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const FetchStatus = zrequire("fetch_status");
 set_global("message_scroll", {
     hide_loading_older: () => {},

diff --git a/frontend_tests/node_tests/filter.js b/frontend_tests/node_tests/filter.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("unread");
 zrequire("stream_data");
 zrequire("people");

diff --git a/frontend_tests/node_tests/fold_dict.js b/frontend_tests/node_tests/fold_dict.js
@@ -1,3 +1,5 @@
+"use strict";
+
 const FoldDict = zrequire("fold_dict").FoldDict;
 
 run_test("basic", () => {

diff --git a/frontend_tests/node_tests/general.js b/frontend_tests/node_tests/general.js
@@ -1,3 +1,5 @@
+"use strict";
+
 // This is a general tour of how to write node tests that
 // may also give you some quick insight on how the Zulip
 // browser app is constructed.  Let's start with testing

diff --git a/frontend_tests/node_tests/hash_util.js b/frontend_tests/node_tests/hash_util.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("hash_util");
 zrequire("stream_data");
 zrequire("people");

diff --git a/frontend_tests/node_tests/hashchange.js b/frontend_tests/node_tests/hashchange.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 const window_stub = $.create("window-stub");
 set_global("location", {

diff --git a/frontend_tests/node_tests/hotkey.js b/frontend_tests/node_tests/hotkey.js
@@ -1,3 +1,5 @@
+"use strict";
+
 // Important note on these tests:
 //
 // The way the Zulip hotkey tests work is as follows.  First, we set

diff --git a/frontend_tests/node_tests/i18n.js b/frontend_tests/node_tests/i18n.js
@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("templates");
 
 // We download our translations in `page_params` (which

diff --git a/frontend_tests/node_tests/input_pill.js b/frontend_tests/node_tests/input_pill.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 zrequire("input_pill");
 

diff --git a/frontend_tests/node_tests/keydown_util.js b/frontend_tests/node_tests/keydown_util.js
@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 zrequire("keydown_util");