Skip to content

Commit

Permalink
github-actions: Use include_frontend_test check.
Browse files Browse the repository at this point in the history
Uses the include_frontend_test instead of platfrom specific check.
  • Loading branch information
priyank-p authored and timabbott committed Jul 8, 2020
1 parent 4938d6a commit 711943a
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/zulip-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
name: Ubuntu 18.04 Bionic (Python 3.6, backend + frontend)
os: bionic
is_bionic: true
include_frontend_tests: true

# This docker image was created by a generated Dockerfile at:
# tools/ci/images/focal/Dockerfile
Expand All @@ -26,6 +27,7 @@ jobs:
name: Ubuntu 20.04 Focal (Python 3.8, backend)
os: focal
is_focal: true
include_frontend_tests: false

runs-on: ubuntu-latest
name: ${{ matrix.name }}
Expand Down Expand Up @@ -107,7 +109,7 @@ jobs:
mispipe "./tools/ci/backend 2>&1" ts
- name: Run frontend tests
if: ${{ matrix.is_bionic }}
if: ${{ matrix.include_frontend_tests }}
run: |
. /srv/zulip-py3-venv/bin/activate
mispipe "./tools/ci/frontend 2>&1" ts
Expand All @@ -119,7 +121,10 @@ jobs:
mispipe "./tools/test-locked-requirements 2>&1" ts
- name: Upload coverage reports
if: ${{ matrix.is_bionic }}

# Only upload coverage when both frontend and backend
# tests are ran.
if: ${{ matrix.include_frontend_tests }}
run: |
# Codcov requires `.coverage` file to be stored in the
# current working directory.
Expand All @@ -137,7 +142,7 @@ jobs:
pip install codecov && codecov || echo "Error in uploading coverage reports to codecov.io."
- name: Store puppeteer artifacts
if: ${{ matrix.is_bionic }}
if: ${{ matrix.include_frontend_tests }}
uses: actions/upload-artifact@v2
with:
name: puppeteer
Expand Down

0 comments on commit 711943a

Please sign in to comment.